feat: box environment#155
Open
l-monninger wants to merge 13 commits into
Open
Conversation
ganymedio
requested changes
Jun 13, 2025
Collaborator
ganymedio
left a comment
ganymedio
left a comment
There was a problem hiding this comment.
Getting this permission denied error in the snapshot test:
Error: failed to copy dir for MovementMigrator
Caused by:
Permission denied (os error 13)
test migrator::movement_migrator::tests::test_snapshot ... FAILED
ganymedio
reviewed
Jun 13, 2025
Contributor
Author
|
It looks like the failure has to do with the user which CI is using when spawning the containers vs. when running the rest of the program. I wonder if |
…nt-core workspace nix shell outside of current nix shell.
sebtomba
reviewed
Jun 17, 2025
| Ok(response) => { | ||
| if response.status().is_success() { | ||
| ready = true; | ||
| continue; |
Contributor
There was a problem hiding this comment.
This appears aggressive. Maybe we could add a delay here?
Contributor
Author
There was a problem hiding this comment.
Yeah, could be good.
chore: rename slect to select
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Provides initial implementation of
boxEnvironment. Additionally, provides the option to snapshot fromlive movementinstance into an isolated instance ofmovement migratorin a manner which partially addresses #136.Note
There are some more complicated API features that make this slightly more friendly in real live environments. But, I am likely going to wait until there's more general exposure to the problems those address before trying to add the to the
boxenvironment. Likely this will depend a bit upon #148.