Bugfix FXIOS-11782 Missing experiment related image identifiers #25733
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Generated by 🚫 Danger Swift against c4ef983 |
lmarceau
approved these changes
Apr 2, 2025
|
@clarmso we need to make sure we backport all the fixes impacted by the tab tray revert in 137 and 138 |
dragosb01
approved these changes
Apr 2, 2025
|
@Mergifyio backport release/v137 release/v138 |
✅ Backports have been created
|
mergify bot
pushed a commit
that referenced
this pull request
Apr 2, 2025
Revert close button back to StandardImageIdentifiers.Large.cross (cherry picked from commit a73eda1) # Conflicts: # firefox-ios/firefox-ios-tests/Tests/XCUITests/TopTabsTest.swift
6 tasks
mergify bot
pushed a commit
that referenced
this pull request
Apr 2, 2025
Revert close button back to StandardImageIdentifiers.Large.cross (cherry picked from commit a73eda1)
mergify bot
pushed a commit
that referenced
this pull request
Apr 2, 2025
Revert close button back to StandardImageIdentifiers.Large.cross (cherry picked from commit a73eda1)
6 tasks
dragosb01
pushed a commit
that referenced
this pull request
Apr 2, 2025
…port #25733) (#25740) Bugfix FXIOS-11782 Missing experiment related image identifiers (#25733) Revert close button back to StandardImageIdentifiers.Large.cross (cherry picked from commit a73eda1) Co-authored-by: Clare So <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📜 Tickets
Jira ticket
💡 Description
After the experiment is disabled, the "x" button should now be
StandardImageIdentifiers.Large.crossfor iPhones. The change should've been in #25690 😄📝 Checklist
You have to check all boxes before merging
@Mergifyio backport release/v120)