Skip to content

Bugfix FXIOS-11782 Missing experiment related image identifiers (backport #25733) #25740

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 2, 2025

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Apr 2, 2025

📜 Tickets

Jira ticket

💡 Description

After the experiment is disabled, the "x" button should now be StandardImageIdentifiers.Large.cross for iPhones. The change should've been in #25690 😄

📝 Checklist

You have to check all boxes before merging

  • Filled in the above information (tickets numbers and description of your work)
  • Updated the PR name to follow our PR naming guidelines
  • Wrote unit tests and/or ensured the tests suite is passing
  • When working on UI, I checked and implemented accessibility (minimum Dynamic Text and VoiceOver)
  • If needed, I updated documentation / comments for complex code and public methods
  • If needed, added a backport comment (example @Mergifyio backport release/v120)

This is an automatic backport of pull request #25733 done by [Mergify](https://mergify.com).

Revert close button back to StandardImageIdentifiers.Large.cross

(cherry picked from commit a73eda1)
@mergify mergify bot requested a review from a team as a code owner April 2, 2025 12:15
@mergify mergify bot requested review from dragosb01 and removed request for a team April 2, 2025 12:15
@mobiletest-ci-bot
Copy link

Messages
📖 Edited 2 files
📖 Created 0 files

Generated by 🚫 Danger Swift against 7106998

@dragosb01 dragosb01 merged commit 015cfd0 into release/v138 Apr 2, 2025
12 checks passed
@dragosb01 dragosb01 deleted the mergify/bp/release/v138/pr-25733 branch April 2, 2025 12:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants