Skip to content

Remove FXIOS-12029 [Feature flag cleanup] Remove the preferSwitchToOpenTabOverDuplicate flag #26202

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Apr 24, 2025
Merged

Remove FXIOS-12029 [Feature flag cleanup] Remove the preferSwitchToOpenTabOverDuplicate flag #26202

merged 4 commits into from
Apr 24, 2025

Conversation

myaumura
Copy link
Contributor

📜 Tickets

Jira ticket
Github issue

💡 Description

Remove preferSwitchToOpenTabOverDuplicate flag since it's not used.

📝 Checklist

You have to check all boxes before merging

  • Filled in the above information (tickets numbers and description of your work)
  • Updated the PR name to follow our PR naming guidelines
  • Wrote unit tests and/or ensured the tests suite is passing
  • When working on UI, I checked and implemented accessibility (minimum Dynamic Text and VoiceOver)
  • If needed, I updated documentation / comments for complex code and public methods
  • If needed, added a backport comment (example @Mergifyio backport release/v120)

@myaumura myaumura requested a review from a team as a code owner April 18, 2025 21:24
@myaumura myaumura requested a review from lmarceau April 18, 2025 21:24
lmarceau
lmarceau reviewed Apr 21, 2025
View reviewed changes
firefox-ios/Client/Nimbus/NimbusFeatureFlagLayer.swift
Comment on lines -344 to -322
private func checkPreferSwitchToOpenTabOverDuplicate(from nimbus: FxNimbus) -> Bool {
return nimbus.features.homescreenFeature.value().preferSwitchToOpenTab
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the PR, we also need to remove the "prefer-switch-to-open-tab" feature flag under the .yaml file here.

lmarceau
lmarceau approved these changes Apr 22, 2025
View reviewed changes
Copy link
Contributor

@lmarceau lmarceau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! There are some minor conflicts to fix, then we'll be ready to merge the changes 💪

@myaumura
Merge branch 'main' of https://github.com/myaumura/firefox-ios into m…
92857d9 
…m/FXIOS-12029-remove-feature-flag-preferSwitchToOpenTabOverDuplicate

# Conflicts:
#	firefox-ios/Client/Frontend/Browser/BrowserViewController/Views/BrowserViewController.swift
@mobiletest-ci-bot
Copy link

mobiletest-ci-bot commented Apr 24, 2025 •
edited
Loading

Messages
📖 Project coverage: 35.21%
📖 Edited 4 files
📖 Created 0 files

Client.app: Coverage: 34.9

File Coverage
BrowserViewController.swift 10.91% ⚠️
NimbusFlaggableFeature.swift 99.33% ✅
NimbusFeatureFlagLayer.swift 71.03% ✅

Generated by 🚫 Danger Swift against b0b5504

@lmarceau
Copy link
Contributor

@Mergifyio rebase

@mergify Mergify
Copy link
Contributor

mergify bot commented Apr 24, 2025

rebase

❌ Base branch update has failed

Git reported the following error:

Rebasing (1/2)
Auto-merging firefox-ios/Client/FeatureFlags/NimbusFlaggableFeature.swift
Auto-merging firefox-ios/Client/Frontend/Browser/BrowserViewController/Views/BrowserViewController.swift
CONFLICT (content): Merge conflict in firefox-ios/Client/Frontend/Browser/BrowserViewController/Views/BrowserViewController.swift
Auto-merging firefox-ios/Client/Nimbus/NimbusFeatureFlagLayer.swift
error: could not apply 166e12072... Remove feature flag
hint: Resolve all conflicts manually, mark them as resolved with
hint: "git add/rm <conflicted_files>", then run "git rebase --continue".
hint: You can instead skip this commit: run "git rebase --skip".
hint: To abort and get back to the state before "git rebase", run "git rebase --abort".
Could not apply 166e12072... Remove feature flag

@lmarceau
Copy link
Contributor

@myaumura could you rebase on main ? There were some changes on the CI pipeline which we'll need to have a passing build 🙏

@myaumura
Copy link
Contributor Author

yep, I'll fix it

@myaumura
Merge branch 'main' of https://github.com/myaumura/firefox-ios into m…
b0b5504 
…m/FXIOS-12029-remove-feature-flag-preferSwitchToOpenTabOverDuplicate
@myaumura
Copy link
Contributor Author

@lmarceau done!

@lmarceau lmarceau merged commit 2b77518 into mozilla-mobile:main Apr 24, 2025
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lmarceau lmarceau lmarceau approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@myaumura @mobiletest-ci-bot @lmarceau