Conversation
moibra05
requested review from
freshstrangemusic,
jaredlockhart,
mikewilli and
yashikakhurana
as code owners
Contributor
Author
|
Contributor
|
@moibra05 it seems like some checks are failing |
Contributor
Author
|
@yashikakhurana i was missing test coverage. fixed now i think 👍 |
| {% if experiment.documentation_links.exists %} | ||
| <div class="d-flex flex-column gap-1"> | ||
| {% for link in experiment.documentation_links.all %} | ||
| <div class="small"> |
Contributor
There was a problem hiding this comment.
hey I see changes in the overview section?
Contributor
Author
There was a problem hiding this comment.
i made some structural changes to how the form sections are rendered so that some of the components are a bit more reusable. i thought that instead of having to create separate _header.html files for each form section it would make more sense to just embed it in the base form component, new_rollout_detail.html. everything is still functionally the same
Contributor
Author
|
yashikakhurana
approved these changes
May 13, 2026
Contributor
yashikakhurana
left a comment
yashikakhurana
left a comment
There was a problem hiding this comment.
Looks good to me, thank you @moibra05
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Because
This commit
Fixes #15078