Skip to content

feat(nimbus): rollouts risks form #15559

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
moibra05 merged 1 commit into from
May 13, 2026
Merged

feat(nimbus): rollouts risks form #15559

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions experimenter/experimenter/nimbus_ui/templates/nimbus_experiments/new_rollout_detail.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,10 +10,10 @@
<div class="d-flex flex-column gap-2">
<div class="small fw-medium mb-1 text-secondary">Define</div>
{# EXP-6681: Rollout Overview Form/Card #}
{% include "nimbus_experiments/overview/card.html" %}
{% include "nimbus_experiments/rollout_cards/new_detail_card.html" with card_id="overview" title="Overview" subtitle="Name · Observations & Problem space · Important Links · Project Tags · Subscribers" show_edit_btn=True body_template="nimbus_experiments/overview/card.html" %}

{# TODO EXP-6682: Rollout Risks Form/Card #}
{% include "nimbus_experiments/rollout_cards/new_detail_card.html" with card_id="risks" title="Risks" subtitle="Consider possible risks if the public interacts with your experiment" %}
{% include "nimbus_experiments/rollout_cards/new_detail_card.html" with card_id="risks" title="Risks" subtitle="Consider possible risks if the public interacts with your experiment" show_edit_btn=True body_template="nimbus_experiments/risks/card.html" %}

</div>
{# ── Configure ── #}
Expand Down
28 changes: 0 additions & 28 deletions experimenter/experimenter/nimbus_ui/templates/nimbus_experiments/overview/_header.html
View file
Open in desktop

This file was deleted.

123 changes: 57 additions & 66 deletions experimenter/experimenter/nimbus_ui/templates/nimbus_experiments/overview/card.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,73 +1,64 @@
<div id="rollout-card-overview"
class="rollout-card rounded-3 border bg-body">
{# ── Card header ── #}
{% include "nimbus_experiments/overview/_header.html" with collapse_target="overview-body" show_edit_btn=True %}

{# ── Collapsible body ── #}
<div id="overview-body" class="collapse show">
<div class="px-4 py-3 d-flex flex-column gap-3">
{# Name #}
<div>
<div class="text-secondary mb-1" style="font-size: 12px;">Name</div>
<div class="small text-body">{{ experiment.name|default:"—" }}</div>
</div>
{# Observations & Problem space #}
<div>
<div class="text-secondary mb-1" style="font-size: 12px;">Observations &amp; Problem space</div>
<div class="small text-body" style="white-space: pre-wrap;">{{ experiment.hypothesis|default:"—" }}</div>
</div>
{# Important Links #}
<div>
<div class="text-secondary mb-1" style="font-size: 12px;">Important Links</div>
{% if experiment.documentation_links.exists %}
<div class="d-flex flex-column gap-1">
{% for link in experiment.documentation_links.all %}
<div class="small">
<a href="{{ link.link }}"
target="_blank"
rel="noopener noreferrer"
class="text-primary text-decoration-none">
{{ link.get_title_display|default:link.link }}
<i class="fa-solid fa-arrow-up-right-from-square fa-2xs ms-1"></i>
</a>
</div>
{% endfor %}
<div class="d-flex flex-column gap-3" id="rollout-overview-body">
{# Name #}
<div>
<div class="text-secondary mb-1" style="font-size: 12px;">Name</div>
<div class="small text-body">{{ experiment.name|default:"—" }}</div>
</div>
{# Observations & Problem space #}
<div>
<div class="text-secondary mb-1" style="font-size: 12px;">Observations &amp; Problem space</div>
<div class="small text-body" style="white-space: pre-wrap;">{{ experiment.hypothesis|default:"—" }}</div>
</div>
{# Important Links #}
<div>
<div class="text-secondary mb-1" style="font-size: 12px;">Important Links</div>
{% if experiment.documentation_links.exists %}
<div class="d-flex flex-column gap-1">
{% for link in experiment.documentation_links.all %}
<div class="small">

@yashikakhurana yashikakhurana May 12, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hey I see changes in the overview section?

@moibra05 moibra05 May 12, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i made some structural changes to how the form sections are rendered so that some of the components are a bit more reusable. i thought that instead of having to create separate _header.html files for each form section it would make more sense to just embed it in the base form component, new_rollout_detail.html. everything is still functionally the same

<a href="{{ link.link }}"
target="_blank"
rel="noopener noreferrer"
class="text-primary text-decoration-none">
{{ link.get_title_display|default:link.link }}
<i class="fa-solid fa-arrow-up-right-from-square fa-2xs ms-1"></i>
</a>
</div>
{% else %}
<div class="small text-body">—</div>
{% endif %}
{% endfor %}
</div>
{# Project Tags #}
<div>
<div class="text-secondary mb-1" style="font-size: 12px;">Project Tags</div>
{% if experiment.tags.exists %}
<div class="d-flex flex-wrap gap-1">
{% for tag in experiment.tags.all %}
<span class="badge rounded-pill small fw-normal"
style="background-color: {{ tag.color }};
color: white">{{ tag.name }}</span>
{% endfor %}
</div>
{% else %}
<div class="small text-body">—</div>
{% endif %}
{% else %}
<div class="small text-body">—</div>
{% endif %}
</div>
{# Project Tags #}
<div>
<div class="text-secondary mb-1" style="font-size: 12px;">Project Tags</div>
{% if experiment.tags.exists %}
<div class="d-flex flex-wrap gap-1">
{% for tag in experiment.tags.all %}
<span class="badge rounded-pill small fw-normal"
style="background-color: {{ tag.color }};
color: white">{{ tag.name }}</span>
{% endfor %}
</div>
{# Subscribers #}
<div>
<div class="text-secondary mb-1" style="font-size: 12px;">Subscribers</div>
{% if experiment.subscribers.exists %}
<div class="d-flex flex-wrap gap-1">
{% for subscriber in experiment.subscribers.all %}
<span class="badge rounded-pill fw-normal small text-body"
style="background-color: var(--bs-secondary-bg);
border: 1px solid var(--bs-border-color)">{{ subscriber.email }}</span>
{% endfor %}
</div>
{% else %}
<div class="small text-body">—</div>
{% endif %}
{% else %}
<div class="small text-body">—</div>
{% endif %}
</div>
{# Subscribers #}
<div>
<div class="text-secondary mb-1" style="font-size: 12px;">Subscribers</div>
{% if experiment.subscribers.exists %}
<div class="d-flex flex-wrap gap-1">
{% for subscriber in experiment.subscribers.all %}
<span class="badge rounded-pill fw-normal small text-body"
style="background-color: var(--bs-secondary-bg);
border: 1px solid var(--bs-border-color)">{{ subscriber.email }}</span>
{% endfor %}
</div>
</div>
{% else %}
<div class="small text-body">—</div>
{% endif %}
</div>
</div>
{# ── Out-of-band: keep the page header name in sync after a save ── #}
Expand Down
Loading
Loading