use MAX instead of SUM for calculating cumulative counts #1264
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
|
✅ Jetstream Validation is complete. Check the CI logs for this step for Query SQL and data processing estimates. |
danielkberry
approved these changes
Dec 8, 2025
Contributor
danielkberry
left a comment
danielkberry
left a comment
There was a problem hiding this comment.
I don't think the metrics.timing_distribution.web_app_usage_time.sum needs a change, since for that one you're just checking if the had any usage. The other 3 LGTM
|
✅ Jetstream Validation is complete. Check the CI logs for this step for Query SQL and data processing estimates. |
bochocki
deleted the
debug_custom_metrics_whats-new-toast-notification-taskbar-tabs-release-v2
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.