fix: Add Ubuntu version to the cache key#3269
Merged
Merged
Conversation
larseggert
requested review from
KershawChang,
martinthomson and
mxinden
as code owners
larseggert
temporarily deployed
to
claude-review
GitHub Actions
Inactive
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3269 +/- ##
==========================================
- Coverage 93.68% 93.66% -0.03%
==========================================
Files 125 125
Lines 37112 37112
Branches 37112 37112
==========================================
- Hits 34770 34760 -10
- Misses 1485 1496 +11
+ Partials 857 856 -1
|
larseggert
temporarily deployed
to
claude-review
GitHub Actions
Inactive
larseggert
changed the title
ImageOS info to the cache key
larseggert
changed the title
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes a cache key collision issue in the NSS build action by incorporating the ImageOS environment variable into the cache key. This ensures that builds on different OS images (e.g., different Ubuntu versions) don't incorrectly share cached artifacts.
Key Changes:
- Modified the NSS cache key to include
ImageOSenvironment variable between the OS name and architecture fields
Contributor
Failed Interop TestsQUIC Interop Runner, client vs. server, differences relative to
All resultsSucceeded Interop TestsQUIC Interop Runner, client vs. server neqo-pr as client
neqo-pr as server
Unsupported Interop TestsQUIC Interop Runner, client vs. server neqo-pr as client
neqo-pr as server
|
Contributor
Client/server transfer resultsPerformance differences relative to 71a4b74. Transfer of 33554432 bytes over loopback, min. 100 runs. All unit-less numbers are in milliseconds.
Table above only shows statistically significant changes. See all results below. All resultsTransfer of 33554432 bytes over loopback, min. 100 runs. All unit-less numbers are in milliseconds.
Download data for |
Contributor
Benchmark resultsSignificant performance differences relative to 71a4b74. 1-conn/1-100mb-req/mtu-1504 (aka. Upload)/client: 💔 Performance has regressed by +1.3252%. time: [209.65 ms 210.11 ms 210.65 ms]
thrpt: [474.73 MiB/s 475.94 MiB/s 476.98 MiB/s]
change:
time: [+1.0550% +1.3252% +1.6374] (p = 0.00 < 0.05)
thrpt: [-1.6110% -1.3078% -1.0440]
Performance has regressed.
Found 3 outliers among 100 measurements (3.00%)
1 (1.00%) low mild
2 (2.00%) high severeAll results1-conn/1-100mb-resp/mtu-1504 (aka. Download)/client: Change within noise threshold. time: [204.34 ms 204.60 ms 204.87 ms]
thrpt: [488.12 MiB/s 488.75 MiB/s 489.38 MiB/s]
change:
time: [-0.7339% -0.4689% -0.2376] (p = 0.00 < 0.05)
thrpt: [+0.2381% +0.4711% +0.7393]
Change within noise threshold.
Found 1 outliers among 100 measurements (1.00%)
1 (1.00%) high mild1-conn/10_000-parallel-1b-resp/mtu-1504 (aka. RPS)/client: No change in performance detected. time: [282.56 ms 284.60 ms 286.68 ms]
thrpt: [34.882 Kelem/s 35.137 Kelem/s 35.391 Kelem/s]
change:
time: [-0.5653% +0.4059% +1.3129] (p = 0.40 > 0.05)
thrpt: [-1.2958% -0.4043% +0.5685]
No change in performance detected.
Found 1 outliers among 100 measurements (1.00%)
1 (1.00%) high mild1-conn/1-1b-resp/mtu-1504 (aka. HPS)/client: No change in performance detected. time: [38.586 ms 38.730 ms 38.891 ms]
thrpt: [25.713 B/s 25.820 B/s 25.916 B/s]
change:
time: [-0.5294% +0.0761% +0.6702] (p = 0.81 > 0.05)
thrpt: [-0.6658% -0.0760% +0.5322]
No change in performance detected.
Found 6 outliers among 100 measurements (6.00%)
2 (2.00%) high mild
4 (4.00%) high severe1-conn/1-100mb-req/mtu-1504 (aka. Upload)/client: 💔 Performance has regressed by +1.3252%. time: [209.65 ms 210.11 ms 210.65 ms]
thrpt: [474.73 MiB/s 475.94 MiB/s 476.98 MiB/s]
change:
time: [+1.0550% +1.3252% +1.6374] (p = 0.00 < 0.05)
thrpt: [-1.6110% -1.3078% -1.0440]
Performance has regressed.
Found 3 outliers among 100 measurements (3.00%)
1 (1.00%) low mild
2 (2.00%) high severedecode 4096 bytes, mask ff: No change in performance detected. time: [4.5153 µs 4.5226 µs 4.5302 µs]
change: [-0.2903% -0.0098% +0.2889] (p = 0.95 > 0.05)
No change in performance detected.
Found 4 outliers among 100 measurements (4.00%)
1 (1.00%) high mild
3 (3.00%) high severedecode 1048576 bytes, mask ff: No change in performance detected. time: [1.1607 ms 1.1625 ms 1.1644 ms]
change: [-0.9257% +0.0352% +0.9970] (p = 0.94 > 0.05)
No change in performance detected.
Found 11 outliers among 100 measurements (11.00%)
11 (11.00%) high severedecode 4096 bytes, mask 7f: No change in performance detected. time: [5.7870 µs 5.7965 µs 5.8065 µs]
change: [-0.6220% -0.2796% +0.0261] (p = 0.09 > 0.05)
No change in performance detected.
Found 3 outliers among 100 measurements (3.00%)
2 (2.00%) high mild
1 (1.00%) high severedecode 1048576 bytes, mask 7f: Change within noise threshold. time: [1.4728 ms 1.4749 ms 1.4772 ms]
change: [-1.6294% -1.0549% -0.6408] (p = 0.00 < 0.05)
Change within noise threshold.
Found 23 outliers among 100 measurements (23.00%)
1 (1.00%) high mild
22 (22.00%) high severedecode 4096 bytes, mask 3f: No change in performance detected. time: [5.5392 µs 5.5505 µs 5.5638 µs]
change: [-0.8704% -0.1687% +0.3375] (p = 0.66 > 0.05)
No change in performance detected.
Found 5 outliers among 100 measurements (5.00%)
2 (2.00%) high mild
3 (3.00%) high severedecode 1048576 bytes, mask 3f: No change in performance detected. time: [1.4151 ms 1.4181 ms 1.4217 ms]
change: [-0.6706% -0.1523% +0.2736] (p = 0.57 > 0.05)
No change in performance detected.
Found 1 outliers among 100 measurements (1.00%)
1 (1.00%) high severe1-streams/each-1000-bytes/wallclock-time: No change in performance detected. time: [581.89 µs 584.41 µs 587.38 µs]
change: [-1.2214% -0.6122% +0.0333] (p = 0.05 > 0.05)
No change in performance detected.
Found 9 outliers among 100 measurements (9.00%)
9 (9.00%) high severe1-streams/each-1000-bytes/simulated-time: No change in performance detected. time: [118.67 ms 118.90 ms 119.13 ms]
thrpt: [8.1975 KiB/s 8.2135 KiB/s 8.2293 KiB/s]
change:
time: [-0.2838% -0.0114% +0.2610] (p = 0.94 > 0.05)
thrpt: [-0.2603% +0.0114% +0.2846]
No change in performance detected.1000-streams/each-1-bytes/wallclock-time: No change in performance detected. time: [12.401 ms 12.439 ms 12.478 ms]
change: [-0.6301% -0.2058% +0.1995] (p = 0.35 > 0.05)
No change in performance detected.
Found 2 outliers among 100 measurements (2.00%)
2 (2.00%) high mild1000-streams/each-1-bytes/simulated-time: No change in performance detected. time: [2.3296 s 2.3328 s 2.3361 s]
thrpt: [428.07 B/s 428.66 B/s 429.27 B/s]
change:
time: [-0.1508% +0.0600% +0.2689] (p = 0.57 > 0.05)
thrpt: [-0.2682% -0.0600% +0.1511]
No change in performance detected.1000-streams/each-1000-bytes/wallclock-time: No change in performance detected. time: [50.146 ms 50.251 ms 50.356 ms]
change: [-0.1168% +0.1734% +0.4896] (p = 0.26 > 0.05)
No change in performance detected.1000-streams/each-1000-bytes/simulated-time: No change in performance detected. time: [16.103 s 16.389 s 16.672 s]
thrpt: [58.574 KiB/s 59.585 KiB/s 60.644 KiB/s]
change:
time: [-3.0773% -0.6488% +1.7592] (p = 0.58 > 0.05)
thrpt: [-1.7288% +0.6530% +3.1750]
No change in performance detected.coalesce_acked_from_zero 1+1 entries: No change in performance detected. time: [89.319 ns 89.670 ns 90.028 ns]
change: [-0.2440% +0.2645% +0.8627] (p = 0.39 > 0.05)
No change in performance detected.
Found 10 outliers among 100 measurements (10.00%)
6 (6.00%) high mild
4 (4.00%) high severecoalesce_acked_from_zero 3+1 entries: No change in performance detected. time: [105.88 ns 106.46 ns 107.21 ns]
change: [-0.5905% -0.1015% +0.3991] (p = 0.70 > 0.05)
No change in performance detected.
Found 12 outliers among 100 measurements (12.00%)
1 (1.00%) high mild
11 (11.00%) high severecoalesce_acked_from_zero 10+1 entries: No change in performance detected. time: [105.18 ns 105.47 ns 105.87 ns]
change: [-0.5948% +0.0705% +0.8969] (p = 0.87 > 0.05)
No change in performance detected.
Found 8 outliers among 100 measurements (8.00%)
4 (4.00%) low mild
4 (4.00%) high severecoalesce_acked_from_zero 1000+1 entries: No change in performance detected. time: [90.762 ns 90.905 ns 91.067 ns]
change: [-0.9118% -0.4365% +0.0276] (p = 0.08 > 0.05)
No change in performance detected.
Found 19 outliers among 100 measurements (19.00%)
2 (2.00%) low mild
10 (10.00%) high mild
7 (7.00%) high severeRxStreamOrderer::inbound_frame(): No change in performance detected. time: [108.66 ms 108.77 ms 108.88 ms]
change: [-0.2215% -0.0730% +0.0746] (p = 0.33 > 0.05)
No change in performance detected.
Found 2 outliers among 100 measurements (2.00%)
2 (2.00%) high mildsent::Packets::take_ranges: No change in performance detected. time: [4.5358 µs 4.6386 µs 4.7314 µs]
change: [-3.0217% +1.5045% +5.9108] (p = 0.52 > 0.05)
No change in performance detected.
Found 3 outliers among 100 measurements (3.00%)
2 (2.00%) high mild
1 (1.00%) high severetransfer/pacing-false/varying-seeds/wallclock-time/run: Change within noise threshold. time: [23.451 ms 23.477 ms 23.513 ms]
change: [+1.0374% +1.1765% +1.3268] (p = 0.00 < 0.05)
Change within noise threshold.
Found 1 outliers among 100 measurements (1.00%)
1 (1.00%) high severetransfer/pacing-false/varying-seeds/simulated-time/run: No change in performance detected. time: [23.941 s 23.941 s 23.941 s]
thrpt: [171.09 KiB/s 171.09 KiB/s 171.09 KiB/s]
change:
time: [+0.0000% +0.0000% +0.0000] (p = NaN > 0.05)
thrpt: [+0.0000% +0.0000% +0.0000]
No change in performance detected.transfer/pacing-true/varying-seeds/wallclock-time/run: Change within noise threshold. time: [23.811 ms 23.834 ms 23.860 ms]
change: [+0.6203% +0.7462% +0.8854] (p = 0.00 < 0.05)
Change within noise threshold.
Found 3 outliers among 100 measurements (3.00%)
1 (1.00%) high mild
2 (2.00%) high severetransfer/pacing-true/varying-seeds/simulated-time/run: No change in performance detected. time: [23.676 s 23.676 s 23.676 s]
thrpt: [173.01 KiB/s 173.01 KiB/s 173.01 KiB/s]
change:
time: [+0.0000% +0.0000% +0.0000] (p = NaN > 0.05)
thrpt: [+0.0000% +0.0000% +0.0000]
No change in performance detected.transfer/pacing-false/same-seed/wallclock-time/run: Change within noise threshold. time: [23.496 ms 23.532 ms 23.581 ms]
change: [+1.2475% +1.4305% +1.6248] (p = 0.00 < 0.05)
Change within noise threshold.
Found 3 outliers among 100 measurements (3.00%)
2 (2.00%) high mild
1 (1.00%) high severetransfer/pacing-false/same-seed/simulated-time/run: No change in performance detected. time: [23.941 s 23.941 s 23.941 s]
thrpt: [171.09 KiB/s 171.09 KiB/s 171.09 KiB/s]
change:
time: [+0.0000% +0.0000% +0.0000] (p = NaN > 0.05)
thrpt: [+0.0000% +0.0000% +0.0000]
No change in performance detected.transfer/pacing-true/same-seed/wallclock-time/run: No change in performance detected. time: [23.964 ms 23.996 ms 24.041 ms]
change: [-0.2862% -0.1262% +0.0740] (p = 0.18 > 0.05)
No change in performance detected.
Found 2 outliers among 100 measurements (2.00%)
2 (2.00%) high severetransfer/pacing-true/same-seed/simulated-time/run: No change in performance detected. time: [23.676 s 23.676 s 23.676 s]
thrpt: [173.01 KiB/s 173.01 KiB/s 173.01 KiB/s]
change:
time: [+0.0000% +0.0000% +0.0000] (p = NaN > 0.05)
thrpt: [+0.0000% +0.0000% +0.0000]
No change in performance detected.Download data for |
larseggert
added a commit
to larseggert/neqo
that referenced
this pull request
Dec 16, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See #3194 (comment)