Skip to content

fix: Add Ubuntu version to the cache key #3269

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
larseggert merged 2 commits into from
Dec 15, 2025
Merged

fix: Add Ubuntu version to the cache key #3269

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a7bd0f3
fix: Add `ImageOS` info to the cache key
larseggert Dec 15, 2025
6341603
ImageOS doesn't exist
larseggert Dec 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 10 additions & 1 deletion .github/actions/nss/action.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -115,13 +115,22 @@ runs:
NSS_HEAD=$(git -C nss rev-parse HEAD)
echo "version=$NSS_HEAD" >> "$GITHUB_OUTPUT"

- name: Store Ubuntu release code name (Linux)
id: ubuntu_release
shell: bash
if: ${{ runner.os == 'Linux' && !steps.system_nss.outputs.suitable && runner.environment == 'github-hosted' }}
run: |
# Store Ubuntu release codename for use in cache key.
. /etc/os-release
echo "codename=-$UBUNTU_CODENAME" >> "$GITHUB_OUTPUT"

- name: Cache NSS
id: cache
if: ${{ !steps.system_nss.outputs.suitable && runner.environment == 'github-hosted' }}
uses: actions/cache@0057852bfaa89a56745cba8c7296529d2fc39830 # v4.3.0
with:
path: dist
key: nss-${{ inputs.target && inputs.target || runner.os }}-${{ runner.arch }}-${{ inputs.type }}-${{ steps.nss.outputs.version }}-${{ steps.nspr.outputs.version }}
key: nss-${{ inputs.target && inputs.target || runner.os }}${{ steps.ubuntu_release.outputs.codename }}-${{ runner.arch }}-${{ steps.nss.outputs.version }}-${{ steps.nspr.outputs.version }}
Comment thread
larseggert marked this conversation as resolved.

- name: Check if build is needed
id: check_build
Expand Down
Loading