[code-infra] Enable undefined addition to optional properties #3302
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brijeshb42
requested review from
atomiks,
colmtuite and
michaldudak
as code owners
brijeshb42
added
the
scope: code-infra
commit: |
Bundle size report
Check out the code infra dashboard for more information about this PR. |
✅ Deploy Preview for base-ui ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
brijeshb42
force-pushed
the
opt-undefined
branch
from
98405e7 to
81fd5f4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Configured a new rule to error only in packages files (no docs or tests). It has autofix to add the
| undefinedtype to the relevant optional types. Currently, it checks for all the optional types and there is not filtering (ie, only properties of exported types, etc). The main change is in the first commit. 2nd commit is the autofix.Fixes - #1916
PR for the eslint rule - mui/mui-public#909