[code-infra] Create custom rule for undefined in optional props #909
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brijeshb42
added
the
scope: code-infra
oliviertassinari
temporarily deployed
to
eslint-undef-plugin - mui-tools-public PR #909
Render
Destroyed
Bundle size report
Check out the code infra dashboard for more information about this PR. |
brijeshb42
force-pushed
the
eslint-undef-plugin
branch
from
7fbea30 to
c00aaca
Compare
brijeshb42
force-pushed
the
eslint-undef-plugin
branch
from
c00aaca to
e6ddef8
Compare
brijeshb42
force-pushed
the
eslint-undef-plugin
branch
from
e6ddef8 to
c57a623
Compare
oliviertassinari
temporarily deployed
to
eslint-undef-plugin - mui-tools-public PR #909
Render
Destroyed
brijeshb42
force-pushed
the
eslint-undef-plugin
branch
from
c57a623 to
74f8ca8
Compare
brijeshb42
force-pushed
the
eslint-undef-plugin
branch
from
74f8ca8 to
31b82ce
Compare
This rule naively (currently) checks for all optional properties in interface and types and provides autofix to add `| undefined` wherever it doesn't exist. One slight optimization is added where locally defined types are also checked for `| undefined` and if it already has `undefined`, its not added at places where the type is used.
brijeshb42
force-pushed
the
eslint-undef-plugin
branch
from
31b82ce to
e8d266b
Compare
1 task
github-actions
bot
added
the
PR: out-of-date
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This rule naively (currently) checks for all optional properties in interface and types and provides autofix to add
| undefinedwherever it doesn't exist.One optimization is added where locally defined types are also checked for
| undefinedand if it already hasundefined, its not added at places where the type is used.See tests for scenarios. We can optimize the discovery further by allowing options to, for example, only affect optional properties of exported types/interface.
Integration PR in Base UI - mui/base-ui#3302