[code-infra] Enable babel-plugin-display-name in vitest
#17903
Conversation
JCQuintas
commented
May 19, 2025
JCQuintas
commented
- I have followed (at least) the PR section of the contributing guide.
|
Thanks for adding a type label to the PR! 👍 |
JCQuintas
added
test
core
|
Deploy preview: https://deploy-preview-17903--material-ui-x.netlify.app/ |
vitest.shared.mts
Outdated
| plugins: [ | ||
| babel({ | ||
| babelConfig: { | ||
| plugins: ['@mui/internal-babel-plugin-display-name'], | ||
| babelrc: false, | ||
| configFile: false, | ||
| }, | ||
| }), | ||
| ], |
There was a problem hiding this comment.
Thanks for looking into this 👍
It might be nice to import our actual babel.config.js as the config there, we have a few plugins that modify the code so it would be nice to test under the same conditions that our code actually runs in production.
There was a problem hiding this comment.
Yeah, but it seems we had decided not to run our babel config in vitest, it would probably require a lot of changes too #17845 (comment)
github-actions
bot
added
the
PR: out-of-date
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
github-actions
bot
removed
the
PR: out-of-date
| @@ -68,7 +68,7 @@ interface DataGridComponent { | |||
| * API: | |||
| * - [DataGrid API](https://mui.com/x/api/data-grid/data-grid/) | |||
| */ | |||
| export const DataGrid = React.memo(DataGridRaw) as DataGridComponent; | |||
| export const DataGrid = React.memo(forwardRef(DataGridRaw)) as DataGridComponent; | |||
There was a problem hiding this comment.
Moved the forwardRef inside the memo to prevent the component name being DataGridRaw, though I don't know if this is ok. I would expect so, since the entire thing is memoized anyways.
JCQuintas
changed the title
babel-plugin-display-name in vitest
| ], | ||
| ], | ||
| babelrc: false, | ||
| configFile: false, |
