-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
[code-infra] Enable babel-plugin-display-name
in vitest
#17903
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
17 commits
Select commit
Hold shift + click to select a range
40d7e55
try custom babel vitest
JCQuintas e49a766
allowall
JCQuintas c5c324d
try react plugin
JCQuintas 4774afa
remvoe forward ref
JCQuintas 76c572b
Merge branch 'master' into run-custom-babel-vitest
JCQuintas 5991db4
add react import back
JCQuintas 87291ab
revert package changes
JCQuintas 1256df0
revert order
JCQuintas 1376c27
add suggestion
JCQuintas 203f669
fix: babel plugin allowed callees
romgrk 54b8f89
lint
romgrk 9944e2f
Merge commit '6495e1545886db424277f9a806a2c196ce91953f' into run-cust…
JCQuintas 3904ae8
move forwardRef inside memo
JCQuintas 5c2a7f0
fix babel
JCQuintas 1ea858b
Revert "fix: babel plugin allowed callees"
JCQuintas 3e61e40
dedupe
JCQuintas 56deab8
Merge branch 'master' into run-custom-babel-vitest
JCQuintas File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,11 +1,30 @@ | ||
import { resolve, dirname } from 'node:path'; | ||
import { fileURLToPath } from 'node:url'; | ||
import { defineConfig } from 'vitest/config'; | ||
import react from '@vitejs/plugin-react'; | ||
|
||
const CURRENT_DIR = dirname(fileURLToPath(import.meta.url)); | ||
const WORKSPACE_ROOT = resolve(CURRENT_DIR, './'); | ||
|
||
export default defineConfig({ | ||
plugins: [ | ||
react({ | ||
babel: { | ||
plugins: [ | ||
[ | ||
'@mui/internal-babel-plugin-display-name', | ||
{ | ||
allowedCallees: { | ||
'@mui/x-internals/forwardRef': ['forwardRef'], | ||
}, | ||
}, | ||
], | ||
], | ||
babelrc: false, | ||
configFile: false, | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 👌 |
||
}, | ||
}), | ||
], | ||
// We seem to need both this and the `env` property below to make it work. | ||
define: { | ||
'process.env.NODE_ENV': '"test"', | ||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Moved the forwardRef inside the memo to prevent the component name being
DataGridRaw
, though I don't know if this is ok. I would expect so, since the entire thing is memoized anyways.https://app.circleci.com/pipelines/github/mui/mui-x/92158/workflows/efcac4b3-6861-4171-b28c-b67d80af2cbb/jobs/538493