Open
Conversation
Ensures curly apostrophes in use-facing strings according to our internal decision.
albin-mullvad
force-pushed
the
add-curly-apostrophe-check-droid-1716
branch
from
66ced24 to
117956b
Compare
albin-mullvad
requested review from
Rawa,
faern,
pinkisemils,
raksooo and
tobias-jarvelov
as code owners
Rawa
approved these changes
Apr 23, 2026
Collaborator
Rawa
left a comment
Rawa
left a comment
There was a problem hiding this comment.
@Rawa reviewed 29 files and all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved.
albin-mullvad
force-pushed
the
add-curly-apostrophe-check-droid-1716
branch
from
8f3932f to
e57906c
Compare
rablador
approved these changes
Apr 23, 2026
Contributor
rablador
left a comment
rablador
left a comment
There was a problem hiding this comment.
@rablador reviewed 29 files and all commit messages.
Reviewable status:
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
This PR adds checks that ensure we use consistent curly apostrophes (or rather avoids straight ones) throughout our English user-facing strings. It also updates a few incorrect strings.
Why
We've had regressions where curly and straight apostrophes are mixed many times.
How
Adds a script and workflow to ensure we use curly apostrophes.
TODO
scripts/check-apostrophe-style.This change is