Skip to content

Hopefully fix fog light flicker precision #4906

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
qaisjp merged 4 commits into from
May 10, 2026
+10 −7
Merged

Hopefully fix fog light flicker precision #4906

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
477248c
Fix vehicle corona/shadow flicker on fogless to foggy weather blend (…
Zephkek May 6, 2026
884bb1e
Merge branch 'master' of https://github.com/multitheftauto/mtasa-blue…
Zephkek May 8, 2026
ea92f35
Fix weather interpolation resync precision for fog transitions.
Zephkek May 8, 2026
c2c3c46
Run clang-format on weather resync precision fix.
Zephkek May 8, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 10 additions & 7 deletions Client/game_sa/CWeatherSA.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,13 +37,16 @@ void CWeatherSA::ResyncInterpolationWithGameClock(unsigned char primary, unsigne
else
{
// Match the value CWeather::Update derives at 0x72B897:
// v0 = (seconds / 60 + minutes) / 60
// Snapping to minutes only would drop seconds and make CTimeCycle::CalcColoursForPoint
// step m_CurrentColours per game-minute, which surfaces as flicker on vehicle coronas
// (m_fSpriteBrightness) and shadows (m_wShadowStrength) when the clock runs fast.
const auto ucMinute = *reinterpret_cast<unsigned char*>(VAR_TimeMinutes);
const auto ucSecond = *reinterpret_cast<unsigned char*>(VAR_TimeSeconds);
const float fInterp = std::min(1.f, static_cast<float>(ucMinute) / 60.f + static_cast<float>(ucSecond) / 3600.f);
// v0 = ((double)seconds * 0.016666668 + (double)minutes) * 0.016666668
// Keep this <= engine v0 to avoid triggering the wrap branch on precision mismatches.
const auto ucMinute = *reinterpret_cast<unsigned char*>(VAR_TimeMinutes);
const auto ucSecond = *reinterpret_cast<unsigned char*>(VAR_TimeSeconds);
const double dInterp = std::min(1.0, (static_cast<double>(ucSecond) * 0.016666668 + static_cast<double>(ucMinute)) * 0.016666668);
float fInterp = static_cast<float>(dInterp);

if (static_cast<double>(fInterp) > dInterp)
fInterp = std::nextafterf(fInterp, 0.0f);
Comment thread
qaisjp marked this conversation as resolved.

MemPutFast<float>(VAR_InterpolationValue, fInterp);
}
}
Expand Down
Loading