Skip to content

Filter WER crash dialogs to fail-fast exceptions only#4907

Open
Dutchman101 wants to merge 1 commit intomultitheftauto:masterfrom
Dutchman101:wer-handling-fix
Open

Filter WER crash dialogs to fail-fast exceptions only#4907
Dutchman101 wants to merge 1 commit intomultitheftauto:masterfrom
Dutchman101:wer-handling-fix

Conversation

@Dutchman101
Copy link
Copy Markdown
Member

_CheckForWerCrash picks up any .dmp file in the private dumps folder and shows a "Security Exception" crash dialog on the next launch. The problem is it doesn't check what kind of exception the dump actually contains - so a C++ exception (like a CEGUI texture load failure, 0xE06D7363) that got dumped by WER would show up as a delayed crash dialog on the next MTA launch, even though the game kept running fine as it wasn't a fatal exception at the time it happened.

Now it checks the exception code in the dump and skips anything that isn't a real fail-fast (0xC0000409 / 0xC0000374). This stops irrelevant crash dialogs from appearing on the next launch when no actual crash happened.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants