Skip to content

Filter WER crash dialogs to fail-fast exceptions only #4907

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Dutchman101 wants to merge 1 commit into
base: master
Choose a base branch
from
+19 −0
Open

Filter WER crash dialogs to fail-fast exceptions only #4907

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 19 additions & 0 deletions Client/loader/CInstallManager.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -650,6 +650,15 @@ SString CInstallManager::_CheckForWerCrash()
{
const auto regs = WerCrash::ExtractRegistersFromMinidump(fullPath);
const DWORD exceptionCode = regs.valid ? regs.exceptionCode : EXCEPTION_STACK_BUFFER_OVERRUN;

// Skip non-fail-fast dumps (e.g. 0xE06D7363 C++ exceptions) -
// those are handled by the normal crash handler, not the WER path.
if (regs.valid && exceptionCode != EXCEPTION_STACK_BUFFER_OVERRUN && exceptionCode != EXCEPTION_HEAP_CORRUPTION)
{
OutputDebugStringA(SString("_CheckForWerCrash: Skipping dump %s with non-fail-fast exception code 0x%08X\n", dumpFile.c_str(), exceptionCode));
continue;
}

const char* exceptionName = (exceptionCode == EXCEPTION_STACK_BUFFER_OVERRUN) ? "Stack Buffer Overrun"
: (exceptionCode == EXCEPTION_HEAP_CORRUPTION) ? "Heap Corruption"
: "Security Exception";
Expand Down Expand Up @@ -796,6 +805,16 @@ SString CInstallManager::_CheckForWerCrash()

const auto regs = WerCrash::ExtractRegistersFromMinidump(fullPath);
const DWORD exceptionCode = regs.valid ? regs.exceptionCode : EXCEPTION_STACK_BUFFER_OVERRUN;

// Skip non-fail-fast dumps (e.g. 0xE06D7363 C++ exceptions) -
// those are handled by the normal crash handler, not the WER path.
if (regs.valid && exceptionCode != EXCEPTION_STACK_BUFFER_OVERRUN && exceptionCode != EXCEPTION_HEAP_CORRUPTION)
{
OutputDebugStringA(
SString("_CheckForWerCrash: Skipping WER dump %s with non-fail-fast exception code 0x%08X\n", dumpFile.c_str(), exceptionCode));
continue;
}

const char* exceptionName = (exceptionCode == EXCEPTION_STACK_BUFFER_OVERRUN) ? "Stack Buffer Overrun"
: (exceptionCode == EXCEPTION_HEAP_CORRUPTION) ? "Heap Corruption"
: "Security Exception";
Expand Down
Loading