0.1.20

[arhtudormorar]

No description provided.

[gemini-code-assist]

Summary of Changes

Hello @arhtudormorar, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request marks a new release, version 0.1.20, for the @multiversx/sdk-dapp-ui library. The primary focus of this update is to enhance the testability of UI components by standardizing and refining the use of data-testid attributes. This includes introducing a specific data-testid for the side panel's close button and making adjustments to the ButtonComponent's data-testid handling to prevent potential issues.

Highlights

• Version Update: The project version has been incremented to 0.1.20 in package.json and documented in CHANGELOG.md.
• Data-TestId Enhancements: A new data-testid (side-panel-close-button) was introduced and applied to the side panel's close button for improved testability.
• Button Component Refinement: The ButtonComponent's internal data-testid assignment logic was adjusted, and its handleClick method was marked as readonly.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Changelog

• CHANGELOG.md
  • Added a new entry for version 0.1.20, noting fixes to data-testids.
• package.json
  • Updated the project version from 0.1.19 to 0.1.20.
• src/common/SidePanel/components/SidePanelHeader/SidePanelHeader.tsx
  • Imported DataTestIdsEnum.
  • Applied DataTestIdsEnum.sidePanelCloseButton to the side panel's right-hand button.
• src/components/visual/button/button.tsx
  • Modified the handleClick method to be readonly.
  • Commented out the direct assignment of data-testid to the ButtonComponent's root element, deferring to a prop-based mechanism.
• src/constants/dataTestIds.enum.ts
  • Added sidePanelCloseButton as a new member to the DataTestIdsEnum.

Activity

• No specific pull request activity (comments, reviews) was provided in the context.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request updates the package version to 0.1.20 and includes changes related to data-testid attributes. While most changes look good, I've found a couple of issues. There is a minor typo in the CHANGELOG.md file. More importantly, there appears to be a regression in the mvx-button component where the data-testid is no longer being passed to the underlying button element, which could impact automated tests. Please see my detailed comments.

[gemini-code-assist]

By commenting out this line, the data-testid prop is no longer passed to the inner ButtonComponent. This will likely break tests that rely on this identifier to find the button element.

The accompanying comment is also misleading:

• reflect: false only prevents the attribute from being added to the host element; it doesn't handle passing the prop to children.
• It refers to internalDataTestId, but the prop is named dataTestId.

It seems this line should be restored to ensure the data-testid is correctly applied to the inner button.

Suggested change

	// data-testid={this.internalDataTestId} // This is handled by the `data-testid` prop with `reflect: false`
	data-testid={this.dataTestId}

[gemini-code-assist]

There's a typo in the changelog entry. 'Fied' should be 'Fixed'.

Suggested change

	- [Fied `data-testid`s](https://github.com/multiversx/mx-sdk-dapp-ui/pull/303)
	- [Fixed `data-testid`s](https://github.com/multiversx/mx-sdk-dapp-ui/pull/303)