-
Notifications
You must be signed in to change notification settings - Fork 2
0.1.20 #304
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
0.1.20 #304
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
|
|
@@ -20,15 +20,15 @@ export class Button { | |||||
| @Prop() size?: `${ButtonSizeEnum}` = 'large'; | ||||||
| @Prop() variant?: `${ButtonVariantEnum}` = 'primary'; | ||||||
|
|
||||||
| private handleClick = (event: MouseEvent) => { | ||||||
| private readonly handleClick = (event: MouseEvent) => { | ||||||
| this.buttonClick.emit(event); | ||||||
| }; | ||||||
|
|
||||||
| render() { | ||||||
| return ( | ||||||
| <ButtonComponent | ||||||
| class={this.class} | ||||||
| data-testid={this.dataTestId} | ||||||
| // data-testid={this.internalDataTestId} // This is handled by the `data-testid` prop with `reflect: false` | ||||||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. By commenting out this line, the The accompanying comment is also misleading:
It seems this line should be restored to ensure the
Suggested change
|
||||||
| disabled={this.disabled} | ||||||
| size={this.size} | ||||||
| variant={this.variant} | ||||||
|
|
||||||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There's a typo in the changelog entry. 'Fied' should be 'Fixed'.