Fix #23898: Make MS recognise the .mscz~ filetype #31352
Conversation
|
There is a reason that MuseScore does not open these by default - to prevent people from opening backup copies accidentally. So I do not think it is appropriate to do this. What might be acceptable is to leave them out of the filter but allow them to be opened directly but with a warning dialog. But that is something to discuss with the design team first, I think, by commenting in the issue thread. |
| @@ -1901,7 +1901,7 @@ async::Promise<io::path_t> ProjectActionsController::selectScoreOpeningFile() co | |||
| "*.ove *.scw *.bmw *.bww *.gtp *.gp3 *.gp4 *.gp5 *.gpx *.gp *.ptb *.mei *.tef *.mscx *.mscs *.mscz~"; | |||
|
|
|||
| std::vector<std::string> filter { muse::trc("project", "All supported files") + " (" + allExt + ")", | |||
| muse::trc("project", "MuseScore files") + " (*.mscz)", | |||
| muse::trc("project", "MuseScore files") + " (*.mscz *.mscz~)", | |||
There was a problem hiding this comment.
It is already listed below in line 1918 as "MuseScore backup files"
|
There is a conflict in .gitignore |
|
|
||
| # QML language server | ||
| **/.qmlls.ini | ||
| CMakeUserPresets.json |
There was a problem hiding this comment.
Some whitespace damage. Certainly not a needed change
|
You'd also need to add that extension somewhere here: MuseScore/buildscripts/packaging/Windows/Installer/WIX.template.in Lines 113 to 143 in baddeb9 and here: MuseScore/buildscripts/packaging/macOS/Info.plist.in Lines 83 to 130 in baddeb9 and here: MuseScore/buildscripts/packaging/Linux+BSD/musescore.xml.in Lines 43 to 63 in baddeb9 |
4 participants
Resolves: #23898 #23898
It adds the .mscz~ extension to the file open dialog filters and updates the isMuseScoreFile validator to recognize backup files as valid ZIP containers.
[ X] I signed the CLA
[ X] The title of the PR describes the problem it addresses
[X ] Each commit's message describes its purpose and effects, and references the issue it resolves
[X] If changes are extensive, there is a sequence of easily reviewable commits
[ X] The code in the PR follows the coding rules
[ X] There are no unnecessary changes
[X ] The code compiles and runs on my machine, preferably after each commit individually
[ X] I created a unit test or vtest to verify the changes I made (if applicable)