Skip to content

Fix #23898: Make MS recognise the .mscz~ filetype #31352

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
gracetai26 wants to merge 3 commits into
base: master
Choose a base branch
from
+7 −4
Open

Fix #23898: Make MS recognise the .mscz~ filetype #31352

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
100968d
Issue #23898 Changed file opening logic and allowed extension types.
gracetai26 Nov 23, 2025
7aac37d
Issue #23898 Allows opening mscz~ as a zip file
gracetai26 Nov 23, 2025
65429c2
#23898 remove unneccesary changes to gitignore
gracetai26 Dec 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,4 +81,4 @@ __pycache__/
/buildscripts/cmake/SetupBuildEnvironment.user.cmake

# CMake User presets
CMakeUserPresets.json
CMakeUserPresets.json
Copy link
Contributor

@Jojo-Schmitz Jojo-Schmitz Dec 5, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some whitespace damage. Certainly not a needed change

7 changes: 5 additions & 2 deletions src/engraving/infrastructure/mscio.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,9 @@ namespace mu::engraving {
//! NOTE The main format is MuseScore, is a zip archive with a specific structure
static const std::string MSCZ = "mscz";

//! NOTE This is the automatically generated backup file.
static const std::string MSCZ_BACKUP = "mscz~";

//! NOTE Before MuseScore 4, MuseScore could save data in one xml file (excluding binary) with `.mscx` extension.
//! Starting from MuseScore 4, only the score domain model store to the `.mscx` file,
//! and other data, such as styles, chordlist, synthesizer settings, etc. are stored in separate files.
Expand All @@ -46,7 +49,7 @@ static const std::string MSCS = "mscs";

inline bool isMuseScoreFile(const std::string& suffix)
{
return suffix == MSCZ || suffix == MSCX || suffix == MSCS;
return suffix == MSCZ || suffix == MSCX || suffix == MSCS || suffix == MSCZ_BACKUP;
}

enum class MscIoMode : unsigned char {
Expand All @@ -58,7 +61,7 @@ enum class MscIoMode : unsigned char {

inline MscIoMode mscIoModeBySuffix(const std::string& suffix)
{
if (suffix == MSCZ) {
if (suffix == MSCZ || suffix == MSCZ_BACKUP) {
return MscIoMode::Zip;
} else if (suffix == MSCX) {
return MscIoMode::Dir;
Expand Down
2 changes: 1 addition & 1 deletion src/project/internal/projectactionscontroller.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1901,7 +1901,7 @@ async::Promise<io::path_t> ProjectActionsController::selectScoreOpeningFile() co
"*.ove *.scw *.bmw *.bww *.gtp *.gp3 *.gp4 *.gp5 *.gpx *.gp *.ptb *.mei *.tef *.mscx *.mscs *.mscz~";

std::vector<std::string> filter { muse::trc("project", "All supported files") + " (" + allExt + ")",
muse::trc("project", "MuseScore files") + " (*.mscz)",
muse::trc("project", "MuseScore files") + " (*.mscz *.mscz~)",
Copy link
Member

@cbjeukendrup cbjeukendrup Dec 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is already listed below in line 1918 as "MuseScore backup files"

muse::trc("project", "MusicXML files") + " (*.mxl *.musicxml *.xml)",
muse::trc("project", "MIDI files") + " (*.mid *.midi *.kar)",
muse::trc("project", "MuseData files") + " (*.md)",
Expand Down