fix(test): wait for track-name update in assertPlayer#321
Merged
Conversation
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Merged
formatBCE
approved these changes
May 2, 2026
Collaborator
|
@teancom looks good! We'll most likely want to prefer "wait" assertions over immediate ones as A nice trick if you spot a flake like this is to stick a Thread.sleep(1000) in before the flaky assertion, see if it passes every time, and if so then replace with a |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A couple tests added in #314 would only intermittently pass (almost always locally, very flaky in CI). This should fix that, if my robot sidekick is right (it worked well locally, but so did the first version).