Skip to content

Calendar: Edit: Recurrence: Move changeRemainder() from UI to logic - try 1 #750

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
benbucksch wants to merge 4 commits into
base: master
Choose a base branch
from
Draft

Calendar: Edit: Recurrence: Move changeRemainder() from UI to logic - try 1 #750

benbucksch wants to merge 4 commits into from

Conversation

@benbucksch
Copy link
Collaborator

@benbucksch benbucksch commented Jul 15, 2025

No description provided.

@benbucksch benbucksch requested a review from NeilRashbrook July 15, 2025 02:23
@benbucksch benbucksch self-assigned this Jul 15, 2025
@benbucksch benbucksch mentioned this pull request Jul 15, 2025
Merged
@benbucksch
Copy link
Collaborator Author

benbucksch commented Jul 15, 2025

@NeilRashbrook It fails in truncate(), because the start doesn't match an occurence. I don't understand why. Could you please fix it?

@benbucksch benbucksch force-pushed the ben/recur-remainder branch 2 times, most recently from b376eab to a7a9a33 Compare July 15, 2025 03:49
@benbucksch
Copy link
Collaborator Author

benbucksch commented Jul 15, 2025

Ideally, truncate() and the new function would work with any date, and the functions would compare >=

@benbucksch
Copy link
Collaborator Author

benbucksch commented Jul 15, 2025 •
edited
Loading

We need 2 new functions:

  • Event.setSeriesEnd(end: Date)
  • RecurrenceRule.getOccurenceOnOrAfter(time: Date): Date returns the occurrence exactly on that time, or the next after that, or null (if there is none after that time)

@NeilRashbrook
Copy link
Collaborator

NeilRashbrook commented Jul 15, 2025

So, one big problem with your current code is that it doesn't actually delete the event you selected...

NeilRashbrook added a commit that referenced this pull request Jul 15, 2025
@NeilRashbrook
New recurrence rule APIs for finding nearby occurrences #750
1df5d49
NeilRashbrook added a commit that referenced this pull request Jul 15, 2025
@NeilRashbrook
New recurrence rule APIs for finding nearby occurrences #750
c37424b
NeilRashbrook added a commit that referenced this pull request Jul 15, 2025
@NeilRashbrook
New recurrence rule APIs for finding nearby occurrences #750
979eee3
NeilRashbrook added a commit that referenced this pull request Jul 15, 2025
@NeilRashbrook
New master event API for changing recurrence rule length #750
5cf9e5f
benbucksch pushed a commit that referenced this pull request Jul 15, 2025
@NeilRashbrook
Calendar: Recurrence: New recurrence rule APIs for finding nearby occ…
672c77f 
…urrences #750 (#759)
benbucksch pushed a commit that referenced this pull request Jul 15, 2025
@NeilRashbrook
Calendar: Recurrence: New API for changing series end #750 (#760)
30fac35
@benbucksch benbucksch force-pushed the ben/recur-remainder branch from 07a63af to 57a0e16 Compare July 15, 2025 23:43
@benbucksch
Copy link
Collaborator Author

benbucksch commented Jul 15, 2025

one big problem with your current code is that it doesn't actually delete the event you selected...

Can you please post the reproduction steps?
And which code function you mean, what you think it should do where?

@benbucksch
Copy link
Collaborator Author

benbucksch commented Jul 16, 2025

This code still doesn't work. When "changing remainder", it deletes all instances after this one, and restores this one to the original instance.

@benbucksch benbucksch mentioned this pull request Jul 16, 2025
Draft
@benbucksch
Copy link
Collaborator Author

benbucksch commented Jul 16, 2025

Alternative #763 has almost the same problem.

@benbucksch benbucksch marked this pull request as draft July 16, 2025 00:45
@benbucksch benbucksch changed the title Calendar: Edit: Remainder: Move code from UI to logic Calendar: Edit: Recurrence: Move changeRemainder() from UI to logic - try 1 Jul 16, 2025
NeilRashbrook
NeilRashbrook reviewed Jul 16, 2025
View reviewed changes
app/logic/Calendar/Event.ts
Comment on lines +759 to +760
* Removes all instances, exceptions and exclusions
* on or after that `end` time. */
Copy link
Collaborator

@NeilRashbrook NeilRashbrook Jul 16, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As I mentioned in #760, this comment is false.

@benbucksch benbucksch force-pushed the master branch 3 times, most recently from d2ed3e0 to 3fc49e6 Compare August 30, 2025 02:31
@benbucksch benbucksch force-pushed the master branch 2 times, most recently from 7d2a658 to 3640c13 Compare November 6, 2025 15:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@NeilRashbrook NeilRashbrook NeilRashbrook left review comments

Assignees

@NeilRashbrook NeilRashbrook

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@benbucksch @NeilRashbrook