Calendar: Edit: Recurrence: Move changeRemainder() from UI to logic - try 2

[benbucksch]

No description provided.

[benbucksch]

Alternative to #750

This code still doesn't work. When "changing remainder", it deletes all instances from here on, including this one.

[NeilRashbrook]

When "changing remainder", it deletes all instances from here on, including this one.

Isn't that the desired behaviour? The new series starts from this instance. (Well, it does if you remember to add it to the calendar...)

[NeilRashbrook]

saveEvent used to add the event to the calendar.

Suggested change

	await saveEvent(master);
	master.finishEditing();
	let newMaster = event.cloneSeriesFromThisInstance();
	await newMaster.save();
	let newMaster = event.cloneSeriesFromThisInstance();
	await newMaster.save();
	newMaster.calendar.events.add(newMaster);

[NeilRashbrook]

event isn't the master here, and you probably want to delete the current instance too:

Suggested change

	let end = new Date(event.startTime);
	event.parentEvent.cancelEditing();
	event.cancelEditing();
	await event.truncateRecurrence();
	await event.setRecurrenceEndTime(end);
	event.parentEvent.cancelEditing();
	event.cancelEditing();
	await event.truncateRecurrencesFromHere();

[NeilRashbrook]

this.recurrenceCase can't be relied upon at this point, because we might have just cleared the recurrence rule.

[NeilRashbrook]

You don't want to save the event here as that tries to turn it from an instance into an exception. (The old truncateRecurrence had await master.save(), which is why it was async.)

Suggested change

	event.truncateRecurrencesFromHere();
	await event.save();
	event.truncateRecurrencesFromHere();
	await event.parentEvent.save();

[NeilRashbrook]

Ditto.

Suggested change

	event.truncateRecurrencesFromHere();
	await event.save();
	event.truncateRecurrencesFromHere();
	await event.parentEvent.save();

[NeilRashbrook]

Not any more it doesn't.

[NeilRashbrook]

oldMaster.recurrenceRule could be null if you changed the frequency in the UI first. (This would replace the remainder of the series with a single event.)

[benbucksch]

When "changing remainder", it deletes all instances from here on, including this one.

Isn't that the desired behaviour? The new series starts from this instance.

Problem is that the new series is not created

(Well, it does if you remember to add it to the calendar...)

Oh, duh! Is that the reason why I work on this since 2 days and nothing works? Is it that silly? sigh