Fix namespace prefix rendering on root element when specified as symbol#251
Merged
Fix namespace prefix rendering on root element when specified as symbol#251
Conversation
mvz
force-pushed
the
root-element-namespace
branch
from
ff2168a to
d512e36
Compare
By uniformly storing the model namespace as a string, we ensure that looking up the namespace succeeds.
mvz
force-pushed
the
root-element-namespace
branch
from
d512e36 to
e33b67f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes an issue where a namespace specified as a symbol would not result in a prefix being rendered on the root element. This meant that parsing the xml generated by
#to_xmlwould fail.