Perf improvement on Polars #340
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for making this pull request. Did you know? You can try it on Binder: Also, the version of ITables developed in this PR can be installed with (this requires |
MarcoGorelli
reviewed
Dec 1, 2024
src/itables/datatables_format.py
Outdated
| except AttributeError: | ||
| # Polars DataFrame | ||
| data = list(df.iter_rows()) | ||
| data = list(df.rows()) |
There was a problem hiding this comment.
just data = df.rows(), you don't need list
Contributor
Author
There was a problem hiding this comment.
of course, sorry
Owner
|
Sounds great, will test in the coming days! |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #340 +/- ##
=======================================
Coverage 94.76% 94.76%
=======================================
Files 24 24
Lines 1280 1280
=======================================
Hits 1213 1213
Misses 67 67 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is to implement one of Marco's suggestions:
#339 (comment)