Skip to content

Perf improvement on Polars #340

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 3, 2024
Merged

Perf improvement on Polars #340

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
908bcbe
Perf improvement
DeaMariaLeon Dec 1, 2024
8db2c15
correcting
DeaMariaLeon Dec 1, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/itables/datatables_format.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -110,7 +110,7 @@ def datatables_rows(df, count=None, warn_on_unexpected_types=False, pure_json=Fa
)
except AttributeError:
# Polars DataFrame
data = list(df.iter_rows())
data = list(df.rows())
Copy link

@MarcoGorelli MarcoGorelli Dec 1, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just data = df.rows(), you don't need list

Copy link
Contributor Author

@DeaMariaLeon DeaMariaLeon Dec 1, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

of course, sorry

import polars as pl

has_bigints = any(
Expand Down