feat(iroh-dns): Improve error messages#4410
Open
Frando wants to merge 2 commits into
Open
Conversation
Frando
marked this pull request as ready for review
July 14, 2026 07:59
|
Documentation for this PR has been generated and is available at: https://n0-computer.github.io/iroh/pr/4410/docs/iroh/ Last updated: 2026-07-15T11:02:52Z |
Frando
force-pushed
the
Frando/improve-dns-errors
branch
from
July 14, 2026 08:03
adf54c4 to
4d08e83
Compare
Frando
force-pushed
the
Frando/improve-dns-errors
branch
from
July 14, 2026 08:39
4d08e83 to
7eeb85a
Compare
flub
requested changes
Jul 14, 2026
| source: AnyError, | ||
| }, | ||
| #[error("Failed to retrieve {kind} record for {host}")] | ||
| Resolve2 { |
Contributor
There was a problem hiding this comment.
AnyError has a downcast_ref method. Can this not be done without breaking the API by trying to downcast it, if it works you get something that carries the host and kind, if not you have to fallback to the current version.
Contributor
|
Please use the checklist as well :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This improves the error message we show when calling
endpoint.connect(endpoint_id, alpn)without internet connectivity, or with DNS blocked or similar.Before:
After:
Breaking Changes
None.
Notes & open questions
The
no connections availableat the end of the message is, unfortunately, all we get from hickory-resolver. This can be improved once we land #4036Change checklist
proposed change and wrote an as clear and concise description as
they could.
intented effect.