Add the birth certificate amendment form for MA - #656
Conversation
|
@kydecker this is ready for review! I also added 3 questions/notes to the PR description. Would love to hear your thoughts 🙏 By the way the PDF uploading tool is reaaaally fucking cool, great work to everyone who contributed to that. The only issue I ran into is that it flagged a radio group as a textfield but that was easy to fix in the schema. |
|
@deammer Thank you for the contribution!! I'm busy tonight but I will take some time to review this and answer your questions tomorrow. |
kydecker
left a comment
There was a problem hiding this comment.
Thank you so much for kicking this off!
I suggested a handful of copy edits below.
In response to your questions:
the form has a weird field called "Contact information" that doesn't really make sense so I ignored it
Yup, totally fine to just exclude this. There are weird elements in some of these PDF forms.
can we make middle names optional? I didn't see a canonical way to do that but maybe I missed it.
The "missing!" highlights are a little rough around the edges right now for things like this (where a field is displayed but intentionally left blank). Don't worry about it for now.
in the exported PDF, the 2 checkboxes are misalinged (I'm using Waterfox 6.6.15). It's misaligned in a way that makes it look like the wrong box is checked...
Oh, bummer, We need to manually move those fields into the correct position. It's possible to do this with pdf-lib, and probably a feature we could build into the PDF Manager... in the meantime, you could try uploading the PDF to the BentoPDF Form Creator, repositioning the fields, and saving the updated PDF.
Finally, I filed an issue to fix the RadioGroup detection in the PDF Manager: #659
It should be a pretty easy fix if you want to bundle it with this PR, otherwise we can tackle it separately!
Thanks again!
|
@kydecker thank you for the review! I've made all the updates you requested + updated Gonna try to fix up the placement of the checkboxes on the form now. |
kydecker
left a comment
There was a problem hiding this comment.
Nice, looking good! I tested the flow and things are working well.
I have a few more content edits, and one thought about potentially removing the supporting documents step. Curious to hear your thoughts!
|
@kydecker thanks for helping me improve this form 🙏 The gender marker step now shows a warning banner when necessary:
I've removed the "Additional documents" step. Instead, there's now a "waive the fees?" step to toggle the "A check or money order for all fees payable..." checkbox:
And I took your suggestion for deriving the name-change decree checkbox based on whether the applicant changed their name(s). |
818ec13 to
30f90a0
Compare
30f90a0 to
93fa605
Compare
93fa605 to
f5201df
Compare
|
Hi @kydecker, I updated this branch with everything that was shipped to Example error: I'll investigate later this week, but maybe it's something you already know how to fix? |
|
@deammer I can take a look at this later today! I think once we get the radio buttons working we should be close to complete. Thanks for sticking this out and sorry for the mid-progress merge conflict! |
kydecker
left a comment
There was a problem hiding this comment.
@deammer Thank you for contributing!
I just pushed a few changes to update the radio group selection logic to work for the new libpdf library.
Also made a handful of smaller copy tweaks for organization.
Great work on this, thank you for your addition!!
|
Thanks @kydecker! |



Changes:
Notes:
I ran into a few weird things, please let me know how you'd like to proceed:
Implements #647. No genAI was used in the process 💅