backend/finance: audit log changes for dashboard GET apis[WIP] - #130
Open
dhruv-1010 wants to merge 1 commit into
Open
backend/finance: audit log changes for dashboard GET apis[WIP]#130dhruv-1010 wants to merge 1 commit into
dhruv-1010 wants to merge 1 commit into
Conversation
dhruv-1010
commented
Mar 5, 2026
dhruv-1010
commented
- enabled dashboard GET API logging [WIP]
| (Just ApiAuthV3 {}, GET) -> True | ||
| (Just ApiAuthV2 {}, _) -> True | ||
| (Just ApiAuthV3 {}, _) -> True | ||
| _ -> False |
Member
There was a problem hiding this comment.
this can be simplified, lines 103-104 are redundant
case (apiT ^. authType, apiT ^. apiType) of
(Just ApiAuthV2 {}, _) -> True
(Just ApiAuthV3 {}, _) -> True
_ -> False
| ~* cE "Kernel.Prelude.Nothing" | ||
| ~$ TH.doEW clientCall | ||
| (GET, False) -> clientCall | ||
| (_, False) -> clientCall |
Member
There was a problem hiding this comment.
also this case is redundant (GET, False) -> clientCall
dhruv-1010
marked this pull request as ready for review
March 5, 2026 08:19
dhruv-1010
force-pushed
the
dashboard-get-api-audit-logs
branch
from
March 5, 2026 12:32
b27a9e6 to
2b73255
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.