Skip to content

backend/finance: audit log changes for dashboard GET apis[WIP] #130

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
dhruv-1010 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

backend/finance: audit log changes for dashboard GET apis[WIP] #130

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
29 changes: 23 additions & 6 deletions lib/namma-dsl/src/NammaDSL/Generator/Haskell/Dashboard/DomainHandler.hs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -97,8 +97,17 @@ generateDomainHandlerDashboard (DefaultImports qualifiedImp simpleImp _packageIm
storeTransactionImports :: [String]
storeTransactionImports =
when_
(any (\apiT -> apiT ^. apiType /= GET) $ input ^. apis)
[ "Domain.Types.Transaction"
( any
( \apiT ->
case (apiT ^. authType, apiT ^. apiType) of
(Just ApiAuthV2 {}, _) -> True
(Just ApiAuthV3 {}, _) -> True
_ -> False

@roman-bodavskiy roman-bodavskiy Mar 5, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this can be simplified, lines 103-104 are redundant

                case (apiT ^. authType, apiT ^. apiType) of
                  (Just ApiAuthV2 {}, _) -> True
                  (Just ApiAuthV3 {}, _) -> True
                  _ -> False

)
(input ^. apis)
)
[ "Domain.Types.Transaction",
"SharedLogic.Transaction"
]

ifValidationRequired :: Bool
Expand Down Expand Up @@ -162,10 +171,18 @@ handlerFunctionDef serverName clientFuncName apiT = do
if useAuth
then vP "checkedMerchantId" <-- vE "merchantCityAccessCheck" ~* vE "merchantShortId" ~* vE "apiTokenInfo.merchant.shortId" ~* vE "opCity" ~* vE "apiTokenInfo.city"
else letStmt "checkedMerchantId" $ vE "skipMerchantCityAccessCheck" ~* vE "merchantShortId"
let transactionWrapper clientCall = case apiT ^. apiType of
GET -> clientCall
_ | not useAuth -> clientCall
_ -> do
let transactionWrapper clientCall = case (apiT ^. apiType, useAuth) of
(GET, True) -> do
TH.noBindSW $
vE "SharedLogic.Transaction.withGetTransactionStoring"
~* (vE "Domain.Types.Transaction.castEndpoint" ~* vE "apiTokenInfo.userActionType")
~* (cE "Kernel.Prelude.Just" ~* cE serverName)
~* (cE "Kernel.Prelude.Just" ~* vE "apiTokenInfo")
~* cE "Kernel.Prelude.Nothing"
~* cE "Kernel.Prelude.Nothing"
~$ TH.doEW clientCall
(_, False) -> clientCall

@roman-bodavskiy roman-bodavskiy Mar 5, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

also this case is redundant (GET, False) -> clientCall

(_, True) -> do
vP "transaction"
<-- vE "SharedLogic.Transaction.buildTransaction"
~* (vE "Domain.Types.Transaction.castEndpoint" ~* vE "apiTokenInfo.userActionType")
Expand Down