Skip to content

Comments

Move tests to root, add pytest.ini_options, and use tox-uv#83

Merged
DragaDoncila merged 6 commits intonapari:mainfrom
TimMonko:tests-org
Oct 27, 2025
Merged

Move tests to root, add pytest.ini_options, and use tox-uv#83
DragaDoncila merged 6 commits intonapari:mainfrom
TimMonko:tests-org

Conversation

@TimMonko
Copy link
Contributor

@TimMonko TimMonko commented Jul 25, 2025

References and relevant issues

Closes #77

Description

  1. moves tests to root and renames to tests (the latter of which, even if we keep in src, should be done according to PY005)
  2. adds pytest.init_options (PP301-PP309)
  3. replaces tox with tox-uv in dependencies to speed up tox runs

@TimMonko TimMonko requested a review from willingc July 25, 2025 03:42
@TimMonko TimMonko changed the title Move tests to root and use tox-uv Move tests to root, add pytest.ini_options, and use tox-uv Jul 25, 2025
Copy link
Contributor

@willingc willingc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good @TimMonko. I've made one small suggestion to assist the user.

@jni
Copy link
Member

jni commented Jul 28, 2025

@TimMonko @willingc before merging this, could you please check and address the discussion on #77?

@willingc
Copy link
Contributor

See #77 (comment) @jni

@TimMonko
Copy link
Contributor Author

TimMonko commented Aug 1, 2025

@jni can you follow-up on this just so we can make a decision for merge ❤️

@jni
Copy link
Member

jni commented Sep 5, 2025

@TimMonko can you please double check that the pyproject.toml/manifest/whatever settings are correct here so that the tests directory is shipped in the sdist? If that's true then please go ahead and merge, according to the discussion in #77. Thank you!!! 🙏

@TimMonko
Copy link
Contributor Author

TimMonko commented Sep 5, 2025

Will check. I'm going to think about the comments more and try to find a simple hybrid to address as many situations as we can. I want to prioritize simplicity, but will make sure we get tests in sdist

Co-authored-by: Carol Willing <carolcode@willingconsulting.com>
Copy link
Contributor

@DragaDoncila DragaDoncila left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pulled this down and built a plugin and confirmed the tests are present in the sdist under the src/ directory. Going to merge now. Thanks @TimMonko!

@DragaDoncila DragaDoncila merged commit 413a4d4 into napari:main Oct 27, 2025
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Reconsider our choice of using _test directory as the default

5 participants