-
Notifications
You must be signed in to change notification settings - Fork 176
tests: fix collect_with_kwargs for polars nightly
#2527
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
TIL: "If a corresponding element does not exist, the shorter collection is ordered first" |
|
I guess I will wait for the release for it to be green π₯¦π |
|
@FBruzzesi it seems like the issue is marcogorelli/variable-brink-glacier builds a The version seems to be grabbed dynamically from the So that seems to lead here py-polars/src/lib.rs#L406-L407. @MarcoGorelli does any of that sound right and/or possible? π |
|
thanks for looking into it - maybe, although it sounds like polars might start doing pre-releases now, so this nightly build might become unneeded |
|
I'm not sure why, but CI is no longer failing on other branches π€ I couldn't find a PR mentioning a revert of (pola-rs/polars#22680) |
@dangotbanned I guess the changes in #2551 π |
MarcoGorelli
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh nice one π |

What type of PR is this? (check all applicable)