Skip to content

Conversation

@FBruzzesi
Copy link
Member

What type of PR is this? (check all applicable)

  • πŸ’Ύ Refactor
  • ✨ Feature
  • πŸ› Bug Fix
  • πŸ”§ Optimization
  • πŸ“ Documentation
  • βœ… Test
  • 🐳 Other

@FBruzzesi
Copy link
Member Author

FBruzzesi commented May 10, 2025

TIL: "If a corresponding element does not exist, the shorter collection is ordered first"

(Pdb) POLARS_VERSION
(1, 29, 0)
(Pdb) POLARS_VERSION > (1, 29)
True

@FBruzzesi
Copy link
Member Author

I guess I will wait for the release for it to be green πŸ₯¦πŸ˜‚

@dangotbanned
Copy link
Member

dangotbanned commented May 14, 2025

@FBruzzesi it seems like the issue is marcogorelli/variable-brink-glacier builds a .whl for main - but it has the version of the current release πŸ€”

The version seems to be grabbed dynamically from the PyO3 package.

So that seems to lead here py-polars/src/lib.rs#L406-L407.
Where the version comes from a complile-time (!env) environment variable CARGO_PKG_VERSION.
Maybe we could set that to the next minor/major version before building polars?

@MarcoGorelli does any of that sound right and/or possible? πŸ˜‚

@MarcoGorelli
Copy link
Member

thanks for looking into it - maybe, although it sounds like polars might start doing pre-releases now, so this nightly build might become unneeded

@dangotbanned
Copy link
Member

dangotbanned commented May 16, 2025

I'm not sure why, but CI is no longer failing on other branches πŸ€”

I couldn't find a PR mentioning a revert of (pola-rs/polars#22680)

@FBruzzesi FBruzzesi marked this pull request as ready for review May 16, 2025 13:09
@FBruzzesi
Copy link
Member Author

I'm not sure why, but CI is no longer failing on other branches πŸ€”

@dangotbanned I guess the changes in #2551 πŸ‘€

Copy link
Member

@MarcoGorelli MarcoGorelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@MarcoGorelli MarcoGorelli merged commit 3992fe3 into main May 16, 2025
32 checks passed
@MarcoGorelli MarcoGorelli deleted the tests/fix-polars-nightly branch May 16, 2025 13:14
@dangotbanned
Copy link
Member

I'm not sure why, but CI is no longer failing on other branches πŸ€”

@dangotbanned I guess the changes in #2551 πŸ‘€

Oh nice one πŸŽ‰

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants