Skip to content

tests: fix collect_with_kwargs for polars nightly #2527

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
MarcoGorelli merged 5 commits into from
May 16, 2025
Merged

tests: fix collect_with_kwargs for polars nightly #2527

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
1a2e6a6
tests: fix collect_with_kwargs for polars nightly
FBruzzesi May 10, 2025
854e774
try with QueryOptFlags
FBruzzesi May 10, 2025
a160ba9
add a trailing zero just because..
FBruzzesi May 10, 2025
23d8586
Merge branch 'main' into tests/fix-polars-nightly
dangotbanned May 12, 2025
ab873c1
Merge branch 'main' into tests/fix-polars-nightly
dangotbanned May 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 9 additions & 2 deletions tests/frame/collect_test.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,8 +8,10 @@
import narwhals as nw
from narwhals.dependencies import get_cudf
from narwhals.dependencies import get_modin
from narwhals.dependencies import get_polars
from narwhals.utils import Implementation
from tests.utils import PANDAS_VERSION
from tests.utils import POLARS_VERSION
from tests.utils import Constructor
from tests.utils import assert_equal_data

Expand Down Expand Up @@ -157,8 +159,13 @@ def test_collect_to_invalid_backend(


def test_collect_with_kwargs(constructor: Constructor) -> None:
pl_kwargs = (
{"optimizations": get_polars().QueryOptFlags(predicate_pushdown=False)}
if POLARS_VERSION > (1, 29, 0)
else {"no_optimization": True}
)
collect_kwargs = {
nw.Implementation.POLARS: {"no_optimization": True},
nw.Implementation.POLARS: pl_kwargs,
nw.Implementation.DASK: {"optimize_graph": False},
nw.Implementation.PYARROW: {},
}
Expand All @@ -168,7 +175,7 @@ def test_collect_with_kwargs(constructor: Constructor) -> None:
result = (
df.lazy()
.select(nw.col("a", "b").sum())
.collect(**collect_kwargs.get(df.implementation, {})) # type: ignore[arg-type]
.collect(**collect_kwargs.get(df.implementation, {}))
)

expected = {"a": [3], "b": [7]}
Expand Down
Loading