fix: incorrect failure name was being used for 0x2311 #89
Conversation
There was a problem hiding this comment.
Good catch! Maybe the code has changed between firmware releases.
Would you be able to double check the rest of the codes are correct in both EGD and EPD? One thing I noticed is that 0x2311 is over current, but for the Platinum, and we are missing that code in the Platinum's list.
For this, I suggest you download the lastest version of EAS II and search for the section "Elmo Emergency Error and Abort List" under the Platinum's EtherCAT Application Manual, and the "Emergency (EMCY)" section under the Gold's CANOpen DS301 Manual.
| @@ -65,7 +65,7 @@ typedef enum { | |||
| typedef enum { | |||
| JSD_EGD_FAULT_OKAY = 0, | |||
| JSD_EGD_FAULT_RESERVED, | |||
| JSD_EGD_FAULT_OVER_CURRENT, | |||
| JSD_EGD_FAULT_SERIAL_FEEDBACK_ERROR, | |||
There was a problem hiding this comment.
In the latest version of EAS 0x2311 shows "Sensor Feedback Error" as the name, not necessarily a serial feedback. I think we should rename the label to JSD_EGD_FAULT_SENSOR_FEEDBACK_ERROR.
|
Hey @d-loret, just responding to let you know I see your ask and I've going over all the error codes to my to-do list :) |
Going through the fault codes, it was found that the naming of one specific fault code was incorrect and did not line up with the Command Reference. This change goes in to fix that.
