fix#78
Closed
areporeporepo wants to merge 2 commits into
Closed
Conversation
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
There was a problem hiding this comment.
Pull request overview
Fixes two user-facing formatting issues in ROSA by correcting streamed token accumulation in astream() and ensuring _print_usage() outputs Rich-formatted markup correctly.
Changes:
- Remove the extra space that was prepended to each streamed token when building
final_outputinastream(). - Switch
_print_usage()fromprint()torich.console.Console().print()so Rich markup is rendered.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
18
to
22
|
|
||
| from rich.console import Console | ||
| from contextlib import contextmanager | ||
| from typing import TYPE_CHECKING, Any, AsyncIterable, Dict, Literal, Optional, Union | ||
|
|
There was a problem hiding this comment.
Import grouping looks off: from rich.console import Console (third-party) is currently placed between stdlib imports (logging and contextlib). Consider grouping stdlib imports together, then third-party (rich/langchain), then local imports to keep a consistent import order.
Suggested change
| from rich.console import Console | |
| from contextlib import contextmanager | |
| from typing import TYPE_CHECKING, Any, AsyncIterable, Dict, Literal, Optional, Union | |
| from contextlib import contextmanager | |
| from typing import TYPE_CHECKING, Any, AsyncIterable, Dict, Literal, Optional, Union | |
| from rich.console import Console |
areporeporepo
force-pushed
the
fix/astream-token-spacing-and-rich-print
branch
from
bb7479d to
ffae7e0
Compare
areporeporepo
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
in favor of #76