Add args to CmdSeqIn#4962
Merged
LeStarch merged 11 commits intonasa:develfrom Apr 27, 2026
Merged
Conversation
LeStarch
requested changes
Apr 7, 2026
Collaborator
|
So is modifying the RUN going to be a separate PR? Why not just do it in this PR, I think they are related. New RUN_ARGS cmd for SeqDispatcher and update existing RUN cmd for FpySeq |
zimri-leisher
suggested changes
Apr 7, 2026
zimri-leisher
suggested changes
Apr 9, 2026
Collaborator
|
Port buffers approved. |
zimri-leisher
approved these changes
Apr 15, 2026
Collaborator
zimri-leisher
left a comment
zimri-leisher
left a comment
There was a problem hiding this comment.
Spectacular work! Let's merge it.
zimri-leisher
approved these changes
Apr 18, 2026
LeStarch
previously approved these changes
Apr 23, 2026
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
There was a problem hiding this comment.
CodeQL found more than 20 potential problems in the proposed changes. Check the Files changed tab for more details.
| this->RUN_ARGS_cmdHandler(opCode, cmdSeq, fileName, block, Svc::SeqArgs{0, 0}); | ||
| } | ||
|
|
||
| void FpySequencer ::RUN_ARGS_cmdHandler( |
|
|
||
| //! Handler implementation for command VALIDATE_ARGS | ||
| //! | ||
| //! Loads and validates a sequence with arguments |
| } | ||
|
|
||
| // RUN_ARGS command dispatches a sequence with optional arguments to the first available sequencer | ||
| void SeqDispatcher ::RUN_ARGS_cmdHandler(const FwOpcodeType opCode, |
| } | ||
|
|
||
| void SeqDispatcher::runSequence(FwIndexType sequencerIdx, const Fw::ConstStringBase& fileName, Fw::Wait block) { | ||
| void SeqDispatcher::runSequence(FwIndexType sequencerIdx, |
| this->m_dispatchedCount++; | ||
| this->tlmWrite_dispatchedCount(this->m_dispatchedCount); | ||
| this->seqRunOut_out(sequencerIdx, this->m_entryTable[sequencerIdx].sequenceRunning); | ||
| this->seqRunOut_out(sequencerIdx, this->m_entryTable[sequencerIdx].sequenceRunning, args); |
| const Fw::StringBase& fileName, //!< The sequence file name | ||
| const Svc::SeqArgs& args //!< Sequence arguments (not currently used) | ||
| ) { | ||
| (void)args; // Suppress unused parameter warning |
| Svc_FpySequencer_SequencerStateMachine::Signal signal, | ||
| const Svc::FpySequencer_SequenceExecutionArgs& value) { | ||
| this->m_sequenceArgs = value.get_buffer(); | ||
| } |
| Svc_FpySequencer_SequencerStateMachine::Signal signal, | ||
| const Svc::FpySequencer_SequenceExecutionArgs& value) { | ||
| this->m_sequenceArgs = value.get_buffer(); | ||
| } |
| // Args must be serialized in F' big-endian format by the caller before being sent | ||
| this->sequencer_sendSignal_cmd_RUN( | ||
| FpySequencer_SequenceExecutionArgs(filename, FpySequencer_BlockState::NO_BLOCK, args)); | ||
| } |
|
|
||
| void CmdSequencerComponentImpl::seqRunIn_handler(FwIndexType portNum, const Fw::StringBase& filename) { | ||
| void CmdSequencerComponentImpl::seqRunIn_handler(FwIndexType portNum, | ||
| const Fw::StringBase& filename, |
| FpySequencer_BlockState block //!< Return command status when complete or not | ||
| ) { | ||
| // Empty args and delegate to RUN_ARGS handler | ||
| this->RUN_ARGS_cmdHandler(opCode, cmdSeq, fileName, block, Svc::SeqArgs{0, 0}); |
| FpySequencer_BlockState block //!< Return command status when complete or not | ||
| ) { | ||
| // Empty args and delegate to RUN_ARGS handler | ||
| this->RUN_ARGS_cmdHandler(opCode, cmdSeq, fileName, block, Svc::SeqArgs{0, 0}); |
| } | ||
|
|
||
| this->sequencer_sendSignal_cmd_RUN(FpySequencer_SequenceExecutionArgs(fileName, block)); | ||
| // Store args for pushArgsToStack action |
| } | ||
|
|
||
| this->sequencer_sendSignal_cmd_RUN(FpySequencer_SequenceExecutionArgs(fileName, block)); | ||
| // Store args for pushArgsToStack action |
| // Args must be serialized in F' big-endian format by the caller before being sent | ||
| this->sequencer_sendSignal_cmd_RUN( | ||
| FpySequencer_SequenceExecutionArgs(filename, FpySequencer_BlockState::NO_BLOCK, args)); | ||
| } |
LeStarch
approved these changes
Apr 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change Description
Add a U8 array to CmdSeqIn to allow pass through arguments from SeqDisp to CmdSequencer / FpySequencer / etc
Rationale
This is a feature to pass through arguments from the SequenceDispatcher to Sequencers (current and future) that support it.
Testing/Review Recommendations
Ensure SequenceDispatch functionality is working, both on fprime and fpy side.
These changes should not break / altar core functionality.
Future Work
This is a chain of pull requests to support arguments in sequences. Future work includes:
AI Usage (see policy)
Claude Code v2.1.92 sonnet used to autocomplete and find instances where CmdSeqIn changes were required.
FPP coding was done by hand and claude was used to autocomplete C++ calls.
All lines of code were human reviewed.
@LeStarch @zimri-leisher