Skip to content

remove explicit install of @vue/compiler-sfc#8238

Open
davetsay wants to merge 1 commit intomasterfrom
8237-explicit-install-of-vuecompiler-sfc-no-longer-needed
Open

remove explicit install of @vue/compiler-sfc#8238
davetsay wants to merge 1 commit intomasterfrom
8237-explicit-install-of-vuecompiler-sfc-no-longer-needed

Conversation

@davetsay
Copy link
Copy Markdown
Contributor

Closes #8237

Describe your changes:

Remove explicit install per https://www.npmjs.com/package/@vue/compiler-sfc recommendations.

All Submissions:

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Is this a notable change that will require a special callout in the release notes? For example, will this break compatibility with existing APIs or projects that consume these plugins?

Author Checklist

  • Changes address original issue?
  • [n/a] Tests included and/or updated with changes?
  • Has this been smoke tested?
  • Have you associated this PR with a type: label? Note: this is not necessarily the same as the original issue.
  • Have you associated a milestone with this PR? Note: leave blank if unsure.
  • Testing instructions included in associated issue OR is this a dependency/testcase change?

Reviewer Checklist

  • Changes appear to address issue?
  • Reviewer has tested changes by following the provided instructions?
  • Changes appear not to be breaking changes?
  • Appropriate automated tests included?
  • Code style and in-line documentation are appropriate?

@davetsay davetsay added this to the Dependency updates milestone Jan 20, 2026
@davetsay davetsay added the type:maintenance tests, chores, or project maintenance label Jan 20, 2026
@davetsay davetsay linked an issue Jan 20, 2026 that may be closed by this pull request
@codecov
Copy link
Copy Markdown

codecov Bot commented Jan 20, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 57.24%. Comparing base (acccc3a) to head (db254cc).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #8238      +/-   ##
==========================================
- Coverage   57.55%   57.24%   -0.32%     
==========================================
  Files         716      716              
  Lines       28663    28663              
  Branches     2762     2762              
==========================================
- Hits        16497    16407      -90     
- Misses      11833    11919      +86     
- Partials      333      337       +4     
Flag Coverage Δ
e2e-ci 63.76% <ø> (-0.07%) ⬇️
e2e-full 41.98% <ø> (-9.23%) ⬇️
unit 47.69% <ø> (-0.61%) ⬇️
see 19 files with indirect coverage changes

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update acccc3a...db254cc. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

type:maintenance tests, chores, or project maintenance

Projects

None yet

Development

Successfully merging this pull request may close these issues.

explicit install of @vue/compiler-sfc no longer needed

1 participant