feat: allow no inject dialogue resource into extra_game_states#1214
Open
RickyYCheng wants to merge 1 commit into
Open
feat: allow no inject dialogue resource into extra_game_states#1214RickyYCheng wants to merge 1 commit into
extra_game_states#1214RickyYCheng wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#1209 raised some security concerns regarding DM.
This PR allows users to reasonably remove the injection of dialogue_resource, as DM is designed to be a stateless addon.
The injection of Godot objects (in this case, dialogue resources) could be used to modify scripts and trigger reloads, which introduces serious issues. The injection of Node objects also poses problems, such as calling
get_tree().quit()or accessing low-level objects likeget_tree().window.ExampleBalloonwill still inject the balloon node itself inballoon.start, but this injection is removable since custom balloons are expected to be designed and implemented by modifying the balloon template. Therefore, no related changes have been made to the balloon behavior.