Skip to content

feat: allow no inject dialogue resource into extra_game_states #1214

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
RickyYCheng wants to merge 1 commit into
base: main
Choose a base branch
from
Open

feat: allow no inject dialogue resource into extra_game_states #1214

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion addons/dialogue_manager/dialogue_manager.gd
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,6 +39,9 @@ var include_singletons: bool = true
## Allow dialogue to call static methods/properties on classes
var include_classes: bool = true

## Allow dialogue to call methods on [code]DialogueResource[/code]
var include_dialogue_resurce: bool = true

## A runtime override for the project setting to ignore missing state values.
var ignore_missing_state_values: bool = false

Expand Down Expand Up @@ -122,7 +125,8 @@ func _get_next_dialogue_line(resource: DialogueResource, key: String = "", extra
extra_game_states = [autoload] + extra_game_states

# Inject "self" into the extra game states.
_inject_state("self", resource, extra_game_states)
if include_dialogue_resurce:
_inject_state("self", resource, extra_game_states)

# Get the line data
var dialogue_line: DialogueLine = await get_line(resource, key, extra_game_states)
Expand Down