fix: add api version kind to statefulset pvc#1104
Open
arcanez wants to merge 2 commits intonats-io:mainfrom
Open
fix: add api version kind to statefulset pvc#1104arcanez wants to merge 2 commits intonats-io:mainfrom
arcanez wants to merge 2 commits intonats-io:mainfrom
Conversation
14 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this fixes #1103
Problem: When using ArgoCD, the NATS StatefulSet always shows a "diff" for
volumeClaimTemplates. This is because the chart omitsapiVersionandkind, which the Kubernetes API server then automatically adds to the live resource. ArgoCD interprets this as a drift from the desired state.Solution: Explicitly add
apiVersion: v1andkind: PersistentVolumeClaimto thejetstream-pvc.yamlandresolver-pvc.yamlfiles.Impact: This is a non-breaking change that ensures the rendered Helm output matches the live cluster state, resulting in a "Healthy/Synced" status in GitOps controllers.
CAVEAT: This may result in a sync error for existing deployments since
volumeClaimTemplatesis immutable, but a delete & recreate of theStatefulSetcan remedy this.