Skip to content

fix: add api version kind to statefulset pvc #1104

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
arcanez wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix: add api version kind to statefulset pvc #1104

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7eed57d
fix: add `apiVersion` & `kind` to StatefulSet PVC
arcanez Dec 22, 2025
2eb8e3a
fix: update tests
arcanez Dec 22, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions helm/charts/nats/files/stateful-set/jetstream-pvc.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,6 @@
{{- with .Values.config.jetstream.fileStore.pvc }}
apiVersion: v1
kind: PersistentVolumeClaim
metadata:
name: {{ .name }}
spec:
Expand Down
2 changes: 2 additions & 0 deletions helm/charts/nats/files/stateful-set/resolver-pvc.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,6 @@
{{- with .Values.config.resolver.pvc }}
apiVersion: v1
kind: PersistentVolumeClaim
metadata:
name: {{ .name }}
spec:
Expand Down
24 changes: 24 additions & 0 deletions helm/charts/nats/test/config_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,6 +73,10 @@ config:
resource10Gi, _ := resource.ParseQuantity("10Gi")
expected.StatefulSet.Value.Spec.VolumeClaimTemplates = []corev1.PersistentVolumeClaim{
{
TypeMeta: v1.TypeMeta{
APIVersion: "v1",
Kind: "PersistentVolumeClaim",
},
ObjectMeta: v1.ObjectMeta{
Name: test.FullName + "-js",
},
Expand Down Expand Up @@ -191,6 +195,10 @@ config:
storageClassGp3 := "gp3"
expected.StatefulSet.Value.Spec.VolumeClaimTemplates = []corev1.PersistentVolumeClaim{
{
TypeMeta: v1.TypeMeta{
APIVersion: "v1",
Kind: "PersistentVolumeClaim",
},
ObjectMeta: v1.ObjectMeta{
Name: test.FullName + "-js",
},
Expand All @@ -207,6 +215,10 @@ config:
},
},
{
TypeMeta: v1.TypeMeta{
APIVersion: "v1",
Kind: "PersistentVolumeClaim",
},
ObjectMeta: v1.ObjectMeta{
Name: test.FullName + "-resolver",
},
Expand Down Expand Up @@ -401,6 +413,10 @@ config:
storageClassGp3 := "gp3"
expected.StatefulSet.Value.Spec.VolumeClaimTemplates = []corev1.PersistentVolumeClaim{
{
TypeMeta: v1.TypeMeta{
APIVersion: "v1",
Kind: "PersistentVolumeClaim",
},
ObjectMeta: v1.ObjectMeta{
Name: test.FullName + "-js",
},
Expand All @@ -418,6 +434,10 @@ config:
},
},
{
TypeMeta: v1.TypeMeta{
APIVersion: "v1",
Kind: "PersistentVolumeClaim",
},
ObjectMeta: v1.ObjectMeta{
Name: test.FullName + "-resolver",
},
Expand Down Expand Up @@ -600,6 +620,10 @@ max_outstanding_catchup: 64MB
resource10Gi, _ := resource.ParseQuantity("10Gi")
expected.StatefulSet.Value.Spec.VolumeClaimTemplates = []corev1.PersistentVolumeClaim{
{
TypeMeta: v1.TypeMeta{
APIVersion: "v1",
Kind: "PersistentVolumeClaim",
},
ObjectMeta: v1.ObjectMeta{
Name: test.FullName + "-js",
},
Expand Down
4 changes: 4 additions & 0 deletions helm/charts/nats/test/resources_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -310,6 +310,10 @@ natsBox:
resource10Gi, _ := resource.ParseQuantity("10Gi")
expected.StatefulSet.Value.Spec.VolumeClaimTemplates = []corev1.PersistentVolumeClaim{
{
TypeMeta: v1.TypeMeta{
APIVersion: "v1",
Kind: "PersistentVolumeClaim",
},
ObjectMeta: v1.ObjectMeta{
Name: test.FullName + "-js",
},
Expand Down