fix: check AddWeightedMappings error in updateAccountClaimsWithRefresh - #8473
Open
waterWang wants to merge 1 commit into
Open
fix: check AddWeightedMappings error in updateAccountClaimsWithRefresh#8473waterWang wants to merge 1 commit into
waterWang wants to merge 1 commit into
Conversation
|
Please review the To correct, please amend the following commits and force-push: |
| // This will overwrite existing entries | ||
| a.AddWeightedMappings(string(sub), mappings...) | ||
| if err := a.AddWeightedMappings(string(sub), mappings...); err != nil { | ||
| s.Warnf("Error updating mappings for account %s: %v", a.Name, err) |
Member
There was a problem hiding this comment.
This wouldn't resolve the issue, as the expected behavior is the following:
A
$SYS.REQ.CLAIMS.UPDATEthat the server cannot fully apply should not report
success
Instead, is there a way to return an error back to the user?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
When an account JWT is pushed via
$SYS.REQ.CLAIMS.UPDATE,updateAccountClaimsWithRefreshcallsAccount.AddWeightedMappingsbut discards the returned error. This means:jwt.Mapping.Validatehas no duplicate check, butAddWeightedMappingsreturnsduplicate entry for %q. The pusher gets200 "jwt updated"while the mapping stays unchanged.NewSubjectTransformreturns an error for invalid transform tokens, which is also silently ignored.Fix
Capture the error from
AddWeightedMappingsand log a warning, so the operator is notified when mapping updates fail silently.References