Skip to content

fix: check AddWeightedMappings error in updateAccountClaimsWithRefresh #8473

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
waterWang wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: check AddWeightedMappings error in updateAccountClaimsWithRefresh #8473

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion server/accounts.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3498,7 +3498,9 @@ func (s *Server) updateAccountClaimsWithRefresh(a *Account, ac *jwt.AccountClaim
}
}
// This will overwrite existing entries
a.AddWeightedMappings(string(sub), mappings...)
if err := a.AddWeightedMappings(string(sub), mappings...); err != nil {
s.Warnf("Error updating mappings for account %s: %v", a.Name, err)

@MauriceVanVeen MauriceVanVeen Aug 17, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This wouldn't resolve the issue, as the expected behavior is the following:

A $SYS.REQ.CLAIMS.UPDATE that the server cannot fully apply should not report
success

Instead, is there a way to return an error back to the user?

}
}
// remove mappings
for _, rmMapping := range removeList {
Expand Down
Loading