[IMPROVED] Deduplicate keys in KeyValue.Keys() and document ListKeys behavior#2029
Open
[IMPROVED] Deduplicate keys in KeyValue.Keys() and document ListKeys behavior#2029
Conversation
…behavior Un-deprecate Keys() and add deduplication using slices.Sort + slices.Compact to handle cases where the server returns duplicate keys during concurrent writes. Add documentation notes to ListKeys and ListKeysFiltered warning about possible duplicates on large buckets with frequent writes. Signed-off-by: Piotr Piotrowski <piotr@synadia.com>
piotrpio
force-pushed
the
fix/kv-keys-dedup
branch
from
a673f8d to
b02f61a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add deduplication to Keys() using slices.Sort + slices.Compact to handle
cases where the server returns duplicate keys during concurrent writes.
Add documentation notes to ListKeys and ListKeysFiltered warning about
possible duplicates on large buckets with frequent writes.
Signed-off-by: Piotr Piotrowski piotr@synadia.com