removed sassc gem; everything should now be working from dart-sass#200
removed sassc gem; everything should now be working from dart-sass#200LeslieJAnderson wants to merge 2 commits intomainfrom
Conversation
LeslieJAnderson
force-pushed
the
rm-sassc-and-move-to-dart-sass
branch
from
ce916e7 to
06f1c3f
Compare
There was a problem hiding this comment.
wow that's all that needed to be done? i'm... surprised this works. where is dart-sass included? is it bundled as part of rails?
There was a problem hiding this comment.
Seems that way! 🤞
So, I traced the stylesheet_link_tag to application.scss. That file uses the Dart Sass module system (@use, @forward) which sassc cannot compile -- it'd throw a syntax error.
As for "where is dart-sass?" -- the project uses the official sass npm package, which is Dart Sass, so the build:css script in package.json should explicitly call the Dart Sass CLI to compile application.scss.
Since everything is compiling and looks correct, I'm assuming the groundwork was already laid, and the sassc gem was still just lingering and causing problems.
There was a problem hiding this comment.
ooh, so the npm package sass in package.json is dart sass. didn't realize that. amazing.
There was a problem hiding this comment.
@LeslieJAnderson actually one more thing, is "cssbundling-rails" still needed?
There was a problem hiding this comment.
Yeah, cssbundling-rails takes care of all the glue work between Rails and the Node-based CSS toolchain; without it we'd need to do a bunch of work to line things up
There was a problem hiding this comment.
Oh cool thanks. btw process nit but can you change the PR title to adhere to git commit message naming conventions (https://cbea.ms/git-commit/) i.e. use present tense, imperative voice
lorenyu
left a comment
lorenyu
left a comment
There was a problem hiding this comment.
LGTM to move the changes over to template-application-rails
|
@LeslieJAnderson I went ahead and made this change upstream since I have other changes that depend on this navapbc/template-application-rails#94 |
2 participants
Ticket
Resolves navapbc/template-application-rails#87
Changes
Context for reviewers
Testing
Preview environment for app
♻️ Environment destroyed ♻️
Preview environment for app-rails
♻️ Environment destroyed ♻️