Skip to content

removed sassc gem; everything should now be working from dart-sass #200

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
LeslieJAnderson wants to merge 2 commits into from
Closed

removed sassc gem; everything should now be working from dart-sass #200

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
06f1c3f
rm sassc gem in favor of dart sass:
LeslieJAnderson Apr 23, 2025
5770df1
linting
LeslieJAnderson Apr 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions app-rails/Gemfile
View file
Open in desktop
Copy link
Copy Markdown
Collaborator

@lorenyu lorenyu Apr 23, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wow that's all that needed to be done? i'm... surprised this works. where is dart-sass included? is it bundled as part of rails?

Copy link
Copy Markdown
Author

@LeslieJAnderson LeslieJAnderson Apr 24, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems that way! 🤞

So, I traced the stylesheet_link_tag to application.scss. That file uses the Dart Sass module system (@use, @forward) which sassc cannot compile -- it'd throw a syntax error.

As for "where is dart-sass?" -- the project uses the official sass npm package, which is Dart Sass, so the build:css script in package.json should explicitly call the Dart Sass CLI to compile application.scss.

Since everything is compiling and looks correct, I'm assuming the groundwork was already laid, and the sassc gem was still just lingering and causing problems.

Copy link
Copy Markdown
Collaborator

@lorenyu lorenyu Apr 24, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ooh, so the npm package sass in package.json is dart sass. didn't realize that. amazing.

Copy link
Copy Markdown
Collaborator

@lorenyu lorenyu Apr 24, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@LeslieJAnderson actually one more thing, is "cssbundling-rails" still needed?

Copy link
Copy Markdown
Author

@LeslieJAnderson LeslieJAnderson Apr 24, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, cssbundling-rails takes care of all the glue work between Rails and the Node-based CSS toolchain; without it we'd need to do a bunch of work to line things up

Copy link
Copy Markdown
Collaborator

@lorenyu lorenyu Apr 24, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh cool thanks. btw process nit but can you change the PR title to adhere to git commit message naming conventions (https://cbea.ms/git-commit/) i.e. use present tense, imperative voice

Original file line number Diff line number Diff line change
Expand Up @@ -88,9 +88,6 @@ group :development do
gem "rubocop-rails-omakase", require: false
gem "rubocop-rspec", require: false

# Sass compiling
gem "sassc", "~> 2.4"

# Test notifications locally without sending the emails
gem "letter_opener"

Expand Down
13 changes: 0 additions & 13 deletions app-rails/Gemfile.lock
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -161,16 +161,6 @@ GEM
logger
faraday-net_http (3.4.0)
net-http (>= 0.5.0)
ffi (1.17.1-aarch64-linux-gnu)
ffi (1.17.1-aarch64-linux-musl)
ffi (1.17.1-arm-linux-gnu)
ffi (1.17.1-arm-linux-musl)
ffi (1.17.1-arm64-darwin)
ffi (1.17.1-x86-linux-gnu)
ffi (1.17.1-x86-linux-musl)
ffi (1.17.1-x86_64-darwin)
ffi (1.17.1-x86_64-linux-gnu)
ffi (1.17.1-x86_64-linux-musl)
globalid (1.2.1)
activesupport (>= 6.1)
i18n (1.14.7)
Expand Down Expand Up @@ -382,8 +372,6 @@ GEM
rexml
ruby-progressbar (1.13.0)
rubyzip (2.4.1)
sassc (2.4.0)
ffi (~> 1.9)
securerandom (0.4.1)
selenium-webdriver (4.29.1)
base64 (~> 0.2)
Expand Down Expand Up @@ -481,7 +469,6 @@ DEPENDENCIES
rspec-rails (~> 6.1.0)
rubocop-rails-omakase
rubocop-rspec
sassc (~> 2.4)
selenium-webdriver
simplecov
sprockets-rails
Expand Down
Loading