Conversation
There was a problem hiding this comment.
Pull request overview
Enables AWS End User Messaging SMS notifications for the infra/app (platform-test) Terraform app configuration so the service can provision SMS-related infrastructure and environment variables.
Changes:
- Turn on
enable_sms_notificationsin the app’s Terraform locals.
| # 2. Sets up IAM permissions for SMS sending | ||
| # 3. Configures SMS delivery tracking and opt-out management | ||
| enable_sms_notifications = false | ||
| enable_sms_notifications = true |
There was a problem hiding this comment.
Enabling enable_sms_notifications here will turn on SMS resources for dev/staging/prod, but the env configs don’t pass sms_sender_phone_number_registration_id/sms_number_type. With the current defaults, notifications-phone-pool will provision a SIMULATOR number (no real SMS delivery). If the intent is real SMS delivery, wire those variables through in the relevant infra/app/app-config/{dev,staging,prod}.tf (or add a validation to fail when enable_sms_notifications is true in non-dev without a registration ID).
Ticket
Resolves #271
Changes
This PR enables SMS Notifications in platform-test app
Testing
Preview environment for app-catala
♻️ Environment destroyed ♻️
Preview environment for app-flask
♻️ Environment destroyed ♻️
Preview environment for app-nextjs
♻️ Environment destroyed ♻️
Preview environment for app-rails
♻️ Environment destroyed ♻️
Preview environment for app