Skip to content

enable sms-notifications in platform-test#272

Merged
jrpbc merged 1 commit intomainfrom
johan/enable-sms-notification
Apr 16, 2026
Merged

enable sms-notifications in platform-test#272
jrpbc merged 1 commit intomainfrom
johan/enable-sms-notification

Conversation

@jrpbc
Copy link
Copy Markdown
Contributor

@jrpbc jrpbc commented Apr 16, 2026

Ticket

Resolves #271

Changes

This PR enables SMS Notifications in platform-test app

Testing

Provide evidence that the code works as expected. Explain what was done for testing and the results of the test plan. Include screenshots, GIF demos, shell commands or output to help show the changes working as expected. ProTip: you can drag and drop or paste images into this textbox.

Preview environment for app-catala

♻️ Environment destroyed ♻️

Preview environment for app-flask

♻️ Environment destroyed ♻️

Preview environment for app-nextjs

♻️ Environment destroyed ♻️

Preview environment for app-rails

♻️ Environment destroyed ♻️

Preview environment for app

@jrpbc jrpbc requested a review from Copilot April 16, 2026 17:56
@jrpbc jrpbc merged commit 855613c into main Apr 16, 2026
44 of 48 checks passed
@jrpbc jrpbc deleted the johan/enable-sms-notification branch April 16, 2026 17:57
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Enables AWS End User Messaging SMS notifications for the infra/app (platform-test) Terraform app configuration so the service can provision SMS-related infrastructure and environment variables.

Changes:

  • Turn on enable_sms_notifications in the app’s Terraform locals.

# 2. Sets up IAM permissions for SMS sending
# 3. Configures SMS delivery tracking and opt-out management
enable_sms_notifications = false
enable_sms_notifications = true
Copy link

Copilot AI Apr 16, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Enabling enable_sms_notifications here will turn on SMS resources for dev/staging/prod, but the env configs don’t pass sms_sender_phone_number_registration_id/sms_number_type. With the current defaults, notifications-phone-pool will provision a SIMULATOR number (no real SMS delivery). If the intent is real SMS delivery, wire those variables through in the relevant infra/app/app-config/{dev,staging,prod}.tf (or add a validation to fail when enable_sms_notifications is true in non-dev without a registration ID).

Copilot uses AI. Check for mistakes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Enable SMS Notifications for platform-test app

2 participants