Skip to content

enable sms-notifications in platform-test #272

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jrpbc merged 1 commit into from
Apr 16, 2026
Merged

enable sms-notifications in platform-test #272

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion infra/app/app-config/main.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@ locals {
# 1. Creates AWS End User Messaging SMS configuration set
# 2. Sets up IAM permissions for SMS sending
# 3. Configures SMS delivery tracking and opt-out management
enable_sms_notifications = false
enable_sms_notifications = true
Copy link

Copilot AI Apr 16, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Enabling enable_sms_notifications here will turn on SMS resources for dev/staging/prod, but the env configs don’t pass sms_sender_phone_number_registration_id/sms_number_type. With the current defaults, notifications-phone-pool will provision a SIMULATOR number (no real SMS delivery). If the intent is real SMS delivery, wire those variables through in the relevant infra/app/app-config/{dev,staging,prod}.tf (or add a validation to fail when enable_sms_notifications is true in non-dev without a registration ID).

Copilot uses AI. Check for mistakes.

# Whether or not the application should enable WAF for the load balancer.
# If enabled:
Expand Down
Loading