Skip to content

fix: initialize with panel with defaultIndex when display: none #903

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
malangfox merged 5 commits into from
Dec 6, 2024
Merged

fix: initialize with panel with defaultIndex when display: none #903

malangfox merged 5 commits into from
Dec 6, 2024

Conversation

@malangfox
Copy link
Contributor

@malangfox malangfox commented Dec 6, 2024

Issue

#902

Details

This fixes #902, by comparing defaultPanel.position and nearestAnchor.panel.position in _moveToInitialPanel

@coveralls
Copy link

coveralls commented Dec 6, 2024 •
edited
Loading

Coverage Status

coverage: 82.892% (+0.004%) from 82.888%
when pulling 4faa6b3 on malangfox:fix/default-panel-index
into 0305df3 on naver:master.

@malangfox malangfox merged commit 9c28672 into naver:master Dec 6, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@daybrush daybrush daybrush approved these changes

@ave10987 ave10987 Awaiting requested review from ave10987

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Initial Panel index is set incorrectly when display: none

3 participants

@malangfox @coveralls @daybrush